-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ubus-tmate to expose tmate control for terminal sharing #839
Conversation
ba96e8a
to
dac253a
Compare
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
==========================================
+ Coverage 72.19% 72.40% +0.21%
==========================================
Files 38 39 +1
Lines 3334 3378 +44
==========================================
+ Hits 2407 2446 +39
- Misses 927 932 +5
Continue to review full report at Codecov.
|
5c1cf22
to
ef81bd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @nicopace. I'll test it out with final version of the limeapp and report back
How do we do with this package that requires a package from a different feed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! Good work Nico!
This is just a "administrative" request (and a reminder for everyone included myself), plase can you modify your commit mesages so they start with the module name that is modified? (like ubus-tmate: fix bla bla
) this greatly simplifies going through the commit logs. And while you are at it some cosmetics: please remove the final dot and use 'fix bla bla' instead of 'fixes bla bla'. Yes, we should add this recomendations in the contributing info.
A quick way to do it is to do: git rebase -i master
and then replace all the pick
by reword
(save and close) and then all the commit mesages will be desplayed for you to be changed.
…darizes output message
ab4b2b2
to
254e62c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've test it against libremesh/lime-app#289 and works great
This PR proposes an interface to a package that allows console sessions to be shared amongst many people.
This is a piece of a feature that will allow, through the lime-app, for users to request support to other networks and be able to monitor what they do with the access it was given, and remove the access once the intervention is done or you don't want them to be accessing your router anymore. It will have as a lime-app screen.
https://user-images.githubusercontent.com/1136597/104211357-bd7a8580-5412-11eb-9d9b-74123590c28e.mp4
(Chrome plays it, Firefox doesn't :( )
Opening it up so to get your general feedback on:
You will have to add the tmate feed to your OpenWRT buildroot to build it
src-git tmate https://github.com/project-openwrt/openwrt-tmate.git
. It needs OpenWRT 19.07.0 as it needs libssh 0.7.6.