Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fbw: support community lime-assets #852

Merged
merged 1 commit into from
Mar 3, 2021
Merged

fbw: support community lime-assets #852

merged 1 commit into from
Mar 3, 2021

Conversation

spiccinini
Copy link
Contributor

@spiccinini spiccinini commented Mar 1, 2021 •
edited

The lime-assets are documented here https://libremesh.org/docs/en_config.html#lime-assets
This PR only adds the lime-assets support to fbw.

The lime-assets of level community are shared as a tar.gz and fetched as part of the first boot wizard config step.

Fixes #846

@spiccinini
fbw: support community lime-assets
f29c8c5 
The lime-assets of level community are shared as a tar.gz and fetched
as part of the first boot wizard config step.
nicopace
nicopace reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@nicopace nicopace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lacks documentation of what lime-assets is and what is it used for, as right now for me is difficult to understand what you wanted to do with it.
How would you document it?
The code looks ok though...

@spiccinini
Copy link
Contributor Author

It lacks documentation of what lime-assets is and what is it used for, as right now for me is difficult to understand what you wanted to do with it.
How would you document it?
The code looks ok though...

Thanks for the review nico!! The lime-assets are documented here https://libremesh.org/docs/en_config.html#lime-assets
This PR only adds the lime-assets support to fbw.

germanferrero
germanferrero approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@germanferrero germanferrero left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spiccinini! It looks great, I didn't test it but I know you did

@spiccinini spiccinini merged commit 97a2881 into libremesh:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopace nicopace nicopace approved these changes

@germanferrero germanferrero germanferrero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firstbootwizard should retrieve /etc/lime-assets/community directory
3 participants
@spiccinini @nicopace @germanferrero