Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tail command to remove first character of the string #891

Merged
merged 2 commits into from Aug 4, 2021
Merged

add tail command to remove first character of the string #891

merged 2 commits into from Aug 4, 2021

Conversation

RhnSharma
Copy link
Contributor

@RhnSharma RhnSharma commented Jul 31, 2021 •
edited

Fixes #888
Hi @ilario, I have made the changes as discussed in #888 (comment).
Let me know if this needs any changes.
Thanks

@ilario
Copy link
Member

ilario commented Aug 1, 2021

I fear I proposed the solution in a rush and it's wrong.
That "$TAG" is going to be used also for "master", right? @spiccinini @aparcar
In that case we have to remove the first character ooonly if it's a tag like v2020.1.
So the | tail -c +2 could be replaced by | perl -pe 's/v([0-9])/$1/' (hoping that that environment has perl).
Sorry @RhnSharma for the mess, could you change the content of this pull request or open another?
Thanks for your patience

@RhnSharma
Copy link
Contributor Author

@ilario I have made the change you suggested. Please take a look at it and let me know if this needs any changes.
Thanks

ilario
ilario approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@ilario ilario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (hoping that perl is available there). We should merge this and then rename the directories in lime-feed.

@ilario ilario requested a review from aparcar August 2, 2021 07:31
@spiccinini
Copy link
Contributor

Looks good to me! thanks for doing it

@spiccinini spiccinini merged commit e133d60 into libremesh:master Aug 4, 2021
@ilario ilario mentioned this pull request Sep 15, 2021
Closed
ilario added a commit that referenced this pull request Sep 14, 2022
@ilario
Update readme of 2020.1 branch and packages feed
6e57167 
The packages on the feed binary repository (https://github.com/libremesh/lime-feed/tree/gh-pages) for the release 2020.1 are stored in the wrong directory (see #888 and #891). This commit should also trigger the Github action for compling the packages and placing them in the right directory (2020.1 instead of v2020.1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiccinini spiccinini spiccinini approved these changes

@ilario ilario ilario approved these changes

@aparcar aparcar Awaiting requested review from aparcar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OPKG does not find our Packages.gz for releases
3 participants
@RhnSharma @ilario @spiccinini