-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax switch vlan filter #900
Conversation
Log carefully which interfaces get configured or discarded by babeld and batadv protocols
Codecov Report
@@ Coverage Diff @@
## master #900 +/- ##
==========================================
- Coverage 74.54% 74.41% -0.14%
==========================================
Files 43 43
Lines 3658 3682 +24
==========================================
+ Hits 2727 2740 +13
- Misses 931 942 +11
Continue to review full report at Codecov.
|
I did not test, but looks like the second %s is missing in the log line "dev_parser found Wifi device". Neither this I tested: can the CPU port be discovered with something like "swconfig dev switch0 help"? What will happen with DSA? The CPU port is not there anymore? |
Log more verbosely this function as it deals with hardware quirks
ae3edad
to
3bafc4d
Compare
It's not that a
Nope it doesn't give that information
DSA should in theory report this information, but many devices have not been ported to DSA yet and I haven't got info on how really do that reliably for devices which have already been ported to DSA. |
Hi! @G10h4ck What do you think about providing an explicit per device file, like the board.json file (or even adding more information to it) ? And maybe do a fallback to the automatic diacovery behaviour if the information is not present? |
We have discussed such an option in the past, but there was some kind of agreement that we didn't want to do this on LibreMesh behalf and that should be addressed on OpenWrt side, where it is half done with |
So I understand that we can merge this, right? |
Info just got at Battlemesh from @arinc9: the CPU ports are the one which have such a file:
Ref. |
that is a really interesting info! Thanks @ilario ! If you can ask also if it is possible to get more informations about the switch in a "standard" way would be great. |
We have the network interfaces DSA creates. Other than that, you can check the devicetree bindings for DSA.
No, the binding on the referred link is only for DSA. Keep in mind that not all targets on OpenWrt use DSA. |
Address recent bug discovered in Quintana Libre with eth1.2 LibreRouter interface being ignored when specific configuration section for it is needed.