watchping: change starting value for last_hook_run #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, *-ok hooks when ping success after service starts, but *-fail hooks doesn't if ping fails. With this change, the same logic applies to both cases.
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
=======================================
Coverage 76.41% 76.41%
=======================================
Files 47 47
Lines 3934 3934
=======================================
Hits 3006 3006
Misses 928 928 Continue to review full report at Codecov.
|
ilario
approved these changes
Jan 14, 2022
spiccinini
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, *-ok hooks run when ping success after the daemon has started,
but *-fail hooks don't in the case that the ping keep failing until timeout .
With this change, the same logic is applied for both cases: success and failure.