ubus-lime-utils place scripts in /etc/udhcpc.user.d/

[ilario]

Fix #927
Still to be tested. Specifically, it is not obvious that it works on OpenWrt 19.07, while it should work on 22.03 as that directory is already present there.

[ilario]

On OpenWrt 19.07 the content of /etc/udhcpc.user.d/ does not get executed and the /etc/udhcpc.user file does not exist ( https://github.com/openwrt/openwrt/tree/openwrt-19.07/package/network/config/netifd/files/etc ), but gets executed if it exists (
https://github.com/openwrt/openwrt/blob/openwrt-19.07/package/network/config/netifd/files/lib/netifd/dhcp.script#L108 ).

On OpenWrt 22.03 the content of /etc/udhcpc.user.d/ does get executed ( https://github.com/openwrt/openwrt/blob/openwrt-22.03/package/network/config/netifd/files/lib/netifd/dhcp.script#L116-L118 ) and the /etc/udhcpc.user file does exist ( https://github.com/openwrt/openwrt/blob/openwrt-22.03/package/network/config/netifd/files/etc/udhcpc.user ).

For having something that works on both we could:
add the /etc/udhcpc.user.d/50-client-wwan-watchping file as in this PR
and
create a uci-defaults script that checks if the /etc/udhcpc.user is already existing and otherwise creates it with some lines executing the /etc/udhcpc.user.d/ content.

Anyone has a better solution?

[codecov-commenter]

Codecov Report

Merging #950 (c4f4df8) into master (626e8b3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
- Coverage   77.72%   77.70%   -0.03%     
==========================================
  Files          52       52              
  Lines        4359     4359              
==========================================
- Hits         3388     3387       -1     
- Misses        971      972       +1     

Impacted Files	Coverage Δ
...kages/lime-system/files/usr/lib/lua/lime/utils.lua	85.50% <0.00%> (-0.30%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ilario]

Situation on OpenWrt 19.07:

• executing manually udhcpc, the script gets executed (causing another issue: ubus-lime-utils uses watchping but does not depend on it and should check for client-wwan before running #956)
• running it from lime-app I didn't try

Situation with OpenWrt 22.03

• executing manually udhcpc, the script does not get executed
• running it from lime-app (after disabling ieee80211s for circumventing lime-app: received "Cannot use Radio 0, it's being used for mesh links" when "Connect to a Mobile Hotspot" #957), the script gets executed

So in my opinion this can be merged.

[ilario]

Ping @spiccinini @G10h4ck @selankon I think this is ready to merge, can you review it?

[G10h4ck]

let's leave this for after retargetting to OpenWrt development version

[ilario]

let's leave this for after retargetting to OpenWrt development version

Ok, makes sense.

[ilario]

Can we merge this now?

[aparcar]

Please go ahead

[G10h4ck]

Please just drop the OpenWrt 19 compatibility script

[ilario]

Thanks for removing the unneeded script!