Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared-state check for babeld file existence before reading it #983

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

ilario
Copy link
Member

@ilario ilario commented Mar 18, 2023

When installing shared-state without Babeld, the following error appears every time shared-state is used:

# shared-state sync dnsmasq-hosts
grep: /var/etc/babeld.conf: No such file or directory

I tested the proposed change and executes the code only if that file is present.

Tell me if you prefer I open also an issue on this.

@ilario ilario requested a review from G10h4ck March 18, 2023 14:46
@codecov-commenter
Copy link

Codecov Report

Merging #983 (94f6d6c) into master (26ab694) will not change coverage.
The diff coverage is n/a.

❗ Current head 94f6d6c differs from pull request most recent head 3c64479. Consider uploading reports for the commit 3c64479 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #983   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files          52       52           
  Lines        4388     4388           
=======================================
  Hits         3416     3416           
  Misses        972      972           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ilario
Copy link
Member Author

ilario commented Mar 19, 2023

Tested this on a router running OpenWrt 22.03

@G10h4ck G10h4ck added the OpenWrt 19.07 compatible Mark pull requests compatible with OpenWrt 19.07, would be nice to merge those before re-targetting label Mar 20, 2023
@G10h4ck G10h4ck merged commit 21499e9 into libremesh:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenWrt 19.07 compatible Mark pull requests compatible with OpenWrt 19.07, would be nice to merge those before re-targetting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants