Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iputils-ping retrocompatibility with OpenWrt 19.07 #999

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

ilario
Copy link
Member

@ilario ilario commented Apr 3, 2023

Fix #794

The ping6retrocompat.mk file was used for compiling with OpenWrt releases having split iputils-ping and iputils-ping6 or single package iputils-ping.

For some reason, it did not work for me, and it is not needed anymore as we are not supporting OpenWrt 19.07 on the master branch (the OpenWrt_19.07_compatible branch has been created for that).

@G10h4ck
Copy link
Member

G10h4ck commented Apr 3, 2023

Removing $(PING6_SYMLINK) dependency will cause ping4 and ping6 not being provided by iputils-ping anymore so shared-state will be broken because it uses ping6 you should also change the occurrences of ping6 into ping -6 at least into shared-state-get_candidates_neigh

@ilario
Copy link
Member Author

ilario commented Apr 3, 2023

Removing $(PING6_SYMLINK) dependency will cause ping4 and ping6 not being provided by iputils-ping anymore so shared-state will be broken because it uses ping6 you should also change the occurrences of ping6 into ping -6 at least into shared-state-get_candidates_neigh

Right, will do. Thanks!

@ilario
Copy link
Member Author

ilario commented Apr 3, 2023

you should also change the occurrences of ping6 into ping -6

Isn't it enough to use ping instead of ping -6?
I did not test yet if they are equivalent, do you have insight on this?

@ilario
Copy link
Member Author

ilario commented Apr 3, 2023

@selankon please check if the modification of get_loss can have any impact on lime-app

I added some commits where I replaced all the occurrences of ping6 with ping.
I did not include the -6 option to ping for decreasing the complexity of the code (you will see that I got rid of some code that was checking if an IP is v4 or v6).
But it would be easy to just revert the commits and replace ping6 with ping -6, if needed.

@G10h4ck
Copy link
Member

G10h4ck commented Apr 14, 2023

should be fine, please test with a few of routers if shared-state keeps discovering neighbors and then we can merge this

@G10h4ck G10h4ck merged commit 3f86e81 into libremesh:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package lime-debug dependency to iputils-ping6
2 participants