Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added support for Saf Integra Access points #7292

Merged
merged 5 commits into from
Sep 8, 2017

Conversation

laf
Copy link
Member

@laf laf commented Sep 5, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7248
Fixes: #7249

image


This change is Reviewable

@laf laf added the Device 🖥️ New or added device support label Sep 5, 2017
@laf
Copy link
Member Author

laf commented Sep 5, 2017

This includes two OS'.

I did originally have them in one but it seemed silly, the code is sort of duplicated but each has it's own MIB and oids so separate seems sensible.

- sysObjectId:
- .1.3.6.1.4.1.7571.100.1.1.7.1
poller_modules:
wifi: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to enable the wifi polling module, that is only legacy.

@scrutinizer-notifier
Copy link

The inspection completed: 3 new issues, 12 updated code elements

@murrant murrant merged commit 455c721 into librenms:master Sep 8, 2017
@lock
Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants