Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering of Health sensor discovery #10485

Merged
merged 3 commits into from Aug 8, 2019

Conversation

@PipoCanaja
Copy link
Contributor

commented Aug 1, 2019

Some LibreNMS users might not want to discover all the supported sensors for an OS. But it is not possible to change the YAML file (prevents upgrades).
This PR allows filtering to occur during the discovery process, from config.php, using the same principles than other filtering already implemented in LibreNMS

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja self-assigned this Aug 1, 2019

PipoCanaja added 2 commits Aug 1, 2019
@murrant
murrant approved these changes Aug 8, 2019
Copy link
Member

left a comment

Looks good

@murrant murrant merged commit 9dfae2f into librenms:master Aug 8, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.