Tidied up html/index.php #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain more about the code you've cut out? Particular the multi-tenancy stuff and the big JS section. |
|
Multi-tenancy is so you can have a few virtualhosts point to the same install but the logo and things changes based on the vhost. All the links to css/js files and the bubble JS section are completely unused now. Rest of the code is formatting changes so that spacing is set correctly so you can see the start and end of statements at a glance. |
|
Is multi-tenancy broken somehow? If it's a working feature, I can't see |
|
Added it back in. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You're going to hate this :(
I've tidied up html/index.php, both code formatting and old code that needed to be removed.
I realise that I could have probably submitted PR's for code removal and code cleanup separately but a lot of the code needs tidying up and I'd prefer to just get through it to be able to work on other things rather than making the PR's easier.