Tidied up html/index.php #107

Merged
merged 2 commits into from Mar 28, 2014

Projects

None yet

2 participants

@laf
Member
laf commented Feb 26, 2014

You're going to hate this :(

I've tidied up html/index.php, both code formatting and old code that needed to be removed.

I realise that I could have probably submitted PR's for code removal and code cleanup separately but a lot of the code needs tidying up and I'd prefer to just get through it to be able to work on other things rather than making the PR's easier.

@paulgear
Member

Can you explain more about the code you've cut out? Particular the multi-tenancy stuff and the big JS section.

@laf
Member
laf commented Mar 11, 2014

Multi-tenancy is so you can have a few virtualhosts point to the same install but the logo and things changes based on the vhost.

All the links to css/js files and the bubble JS section are completely unused now.

Rest of the code is formatting changes so that spacing is set correctly so you can see the start and end of statements at a glance.

@paulgear
Member

Is multi-tenancy broken somehow? If it's a working feature, I can't see
why we'd want to remove it.

@laf
Member
laf commented Mar 12, 2014

Added it back in.

@paulgear paulgear merged commit 3c96731 into librenms:master Mar 28, 2014

1 check passed

default Scrutinizer: No new issues
Details
@pcupac pcupac referenced this pull request May 3, 2016
Closed

Services don't work #3476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment