Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppet Agent Monitoring #10827

Merged
merged 7 commits into from
Feb 12, 2020
Merged

Puppet Agent Monitoring #10827

merged 7 commits into from
Feb 12, 2020

Conversation

SourceDoctor
Copy link
Member

@SourceDoctor SourceDoctor commented Nov 16, 2019 •
edited
Loading

monitoring puppet Agents

About Puppet:

Puppet is a mighty continuous delivery System to keep all your Servers up to date and in sync.
Also reinstallation/configuration will be massivly speeded up.

A good description/example what puppet is and can do:

https://www.guru99.com/puppet-tutorial.html

Official Page:
https://puppet.com/docs/

matching librenms-agent:
librenms/librenms-agent#258

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 10827
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja
Copy link
Contributor

@SourceDoctor Please keep the PR structure :)

@SourceDoctor
Copy link
Member Author

@PipoCanaja
i think you mean the text you edited in?

@PipoCanaja
Copy link
Contributor

Absolutely, Whatever is after DO NOT DELETE THIS TEXT

@SourceDoctor
Copy link
Member Author

ok :)

@SourceDoctor
Copy link
Member Author

SourceDoctor commented Nov 17, 2019 •
edited
Loading

added Device Overview Panel:

image

@SourceDoctor SourceDoctor changed the title puppet agent monitoring Puppet Agent Monitoring Nov 19, 2019
@SourceDoctor
Copy link
Member Author

@maintainer
is someone using Puppet to check and verify this PR? :-)

@SourceDoctor
Copy link
Member Author

@PipoCanaja still not labeled after 2 month?
unusual for you ;-)

@SourceDoctor SourceDoctor mentioned this pull request Jan 9, 2020
Merged
@PipoCanaja
Copy link
Contributor

Hi @SourceDoctor
Absolutely no idea about puppet, no way to test this. @librenms/testers, anybody using puppet ?

@SourceDoctor
Copy link
Member Author

SourceDoctor commented Jan 19, 2020 •
edited
Loading

Hi @PipoCanaja

You'll love Puppet if running a lot of Linux Systems.
Especially if many of them are similiar.
Even if you only have to keep SSH Keys in sync on all of this Systems.

Similar continuous delivery Systems are Chef, Ansible and Saltstack.

@PipoCanaja
Copy link
Contributor

I am a poor network engineer :) not in charge of the systems :p But I'll have a look at some time. Until then, we need to find out a tester for this :D

@SourceDoctor
Copy link
Member Author

@PipoCanaja
on my System for Tests and Development it's running fine, but i believe that's not enough ;)

@PipoCanaja
Copy link
Contributor

@PipoCanaja
on my System for Tests and Development it's running fine, but i believe that's not enough ;)

That's a very good beginning indeed :)

@SourceDoctor SourceDoctor requested a review from a team February 11, 2020 23:37
@Jellyfrog Jellyfrog merged commit 53dc564 into librenms:master Feb 12, 2020
@Jellyfrog
Copy link
Member

@SourceDoctor ah, crap. Forgot to ask you to generate testdata. Could you open a pr with that?

@SourceDoctor
Copy link
Member Author

@Jellyfrog
i'll do.
n.p. :-)

cjwbath pushed a commit to cjwbath/librenms that referenced this pull request Feb 27, 2020
@SourceDoctor @cjwbath
Puppet Agent Monitoring (librenms#10827)
1703f45 
* puppet agent monitoring

* change position of last run graph

* device overview panel

* updating documentation

* mouseover for Overview Dashboard

* adding blank line for code climate
@murrant
Copy link
Member

murrant commented Mar 2, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-61-release-changelog-february-2020/11145/1

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jellyfrog Jellyfrog Jellyfrog approved these changes

Assignees
No one assigned
Labels
Applications 💾 Feature WebUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SourceDoctor @PipoCanaja @Jellyfrog @murrant @kkrumm1