Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a space for times like '1 minute' #11105

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Add a space for times like '1 minute' #11105

merged 2 commits into from
Feb 5, 2020

Conversation

josephtingiris
Copy link
Contributor

@josephtingiris josephtingiris commented Feb 5, 2020

  • Times like '1 minute' get displayed as '1minute' which is inconsistent with the other times that display with a space after the integer.
  • This patch adds a space for short times like '1 minute'

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@kkrumm1 kkrumm1 added the WebUI label Feb 5, 2020
@kkrumm1
Copy link
Member

kkrumm1 commented Feb 5, 2020

LGTM

@josephtingiris josephtingiris changed the title Add a space for short times like '1 minute' Add a space for times like '1 minute' Feb 5, 2020
@kkrumm1 kkrumm1 merged commit bf35226 into librenms:master Feb 5, 2020
@murrant
Copy link
Member

murrant commented Mar 2, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-61-release-changelog-february-2020/11145/1

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants