Fix case sensitiv translations #11463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jellyfrog looks good but I did a quick search and found at least this |
|
Oh I didn't check for |
On case insensitive systems, @lang('Auth') would match the auth.php file and return an array instead of the string "Auth", causing a "Array to string conversion error"
Jellyfrog
force-pushed
the
feature/lang-case-sensitivity
branch
from
cfc2e1e
to
63b67ce
Compare
|
Fixed |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/v1-63-release-changelog-april-2020/11828/1 |
LEV82
pushed a commit
to LEV82/librenms
that referenced
this pull request
May 14, 2020
On case insensitive systems, @lang('Auth') would match the auth.php file and return an array instead of the string "Auth", causing a "Array to string conversion error"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On case insensitive systems,
@lang('Auth')would match the auth.php fileand return an array instead of the string "Auth", causing a "Array to string conversion error"
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.