Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer graphs: fix evaluation order so unauthenticated access works #11485

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

Zaxmy
Copy link
Contributor

@Zaxmy Zaxmy commented Apr 25, 2020

Closes #11484

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2020

CLA assistant check
All committers have signed the CLA.

@Jellyfrog Jellyfrog merged commit 7bfc2f9 into librenms:master Apr 26, 2020
@murrant murrant changed the title Fixes evaluation order so unathenticated access works Billing graphs: fix evaluation order so unauthenticated access works Apr 27, 2020
@murrant murrant changed the title Billing graphs: fix evaluation order so unauthenticated access works Customer graphs: fix evaluation order so unauthenticated access works Apr 27, 2020
@murrant
Copy link
Member

murrant commented Apr 28, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-63-release-changelog-april-2020/11828/1

LEV82 pushed a commit to LEV82/librenms that referenced this pull request May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call on uninstanciated Auth::User() when using unauthenticated access for customer graphs
4 participants