Validate PHP version mismatch #11621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $web_version = PHP_VERSION; | ||
| $cli_version = rtrim(shell_exec('php -r "echo PHP_VERSION;"')); | ||
| if (version_compare($web_version, $cli_version, '!=')) { | ||
| $validator->fail("PHP version of your webserver ($web_version) does not match the cli version ($cli_version)", "If you updated PHP recently, restart php-fpm or apache to switch to the new version"); |
There was a problem hiding this comment.
mmh ... "restart php-fpm, apache. nginx or what webserver you use.. " ?
There was a problem hiding this comment.
restarting nginx will never have any affect on the php version.
There was a problem hiding this comment.
and you can use php-fpm with apache
There was a problem hiding this comment.
To nitpick you can run php other ways than php-fpm in that case, Nginx unit is one way :)
Point is we can't cover all use cases, some things need to be left to the sysadmin.
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/v1-64-release-changelog-may-2020/12290/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the webserver does not match the cli version this means they recently upgraded and have not restarted the service.
This can cause errors with some cached data.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.