Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation and other issues when config.php is missing #11867

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

murrant
Copy link
Member

@murrant murrant commented Jun 28, 2020

config.php is not strictly required, fix some validation issues in that scenario

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added this to the 1.65 milestone Jun 29, 2020
@murrant murrant merged commit aac2579 into librenms:master Jun 29, 2020
@murrant murrant deleted the more-install-changes branch June 29, 2020 22:49
@murrant
Copy link
Member Author

murrant commented Jul 3, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-65-release-changelog-june-2020/12687/1

1 similar comment
@murrant
Copy link
Member Author

murrant commented Jul 3, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-65-release-changelog-june-2020/12687/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant