Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS: Add support for Beagleboard #12060

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Conversation

arrmo
Copy link
Contributor

@arrmo arrmo commented Sep 6, 2020

Includes Beagleboard and Beaglebone boards. Also includes temperature
sensor support (also in test data)

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@arrmo
Copy link
Contributor Author

arrmo commented Sep 6, 2020

One question - should this be added to https://github.com/librenms/librenms/blob/master/doc/Extensions/Applications.md#raspberry-pi

As it's very similar (identical?) to the Raspberry Pi approach?

Thanks!

@Jellyfrog Jellyfrog added the Device 🖥️ New or added device support label Sep 6, 2020
@Jellyfrog
Copy link
Member

@arrmo
Copy link
Contributor Author

arrmo commented Sep 6, 2020

Tests fails also, https://travis-ci.com/github/librenms/librenms/jobs/381601311

Yes, I saw that too, looked at the failure - it makes no sense to me 😞. Confirmed locally, and the result is as expected. Any thoughts?

Thanks!

@arrmo arrmo force-pushed the beagleboard branch 2 times, most recently from c6de5a2 to a1337bf Compare September 7, 2020 22:58
@arrmo
Copy link
Contributor Author

arrmo commented Sep 7, 2020

Tests fails also, https://travis-ci.com/github/librenms/librenms/jobs/381601311

I see the issue! Why is it assuming / using the os name (beagleboard) for the community? If I use public instead - it works. I admit, not sure where to set that.

=> OK, just checked (database) ... for this device the community is "public". So why is the test using a different community? Hmmm.

@arrmo arrmo force-pushed the beagleboard branch 3 times, most recently from bd11078 to 7f35997 Compare September 8, 2020 01:26
Includes Beagleboard and Beaglebone boards. Also includes temperature
sensor support (also in test data)
@Jellyfrog Jellyfrog merged commit 891a42e into librenms:master Sep 9, 2020
@arrmo arrmo deleted the beagleboard branch September 9, 2020 23:51
damonreed pushed a commit to damonreed/librenms that referenced this pull request Sep 15, 2020
Includes Beagleboard and Beaglebone boards. Also includes temperature
sensor support (also in test data)
@murrant
Copy link
Member

murrant commented Sep 30, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-68-release-changelog-september-2020/13525/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants