Fix CiHelper function checkPythonExec to use 'pip3 install --user' and improve error message #12097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the code validation script on an install that hadn't been verified before, pip3 failed when trying to install pylint.
CiHelper was trying to install the dependency (pylint in this case) for the entire system, which is a privileged operation. Also, the error message was inaccurate for what was happening.
I compared this to how the main dependencies are checked/installed:
https://github.com/librenms/librenms/blob/f526ba326b21727ac3025e062437812ce5e6d20e/composer.json
This makes sense to me, so I added a --user flag to the CIHelper check, and the install now runs cleanly.
Also fixed the error message to reflect the actual target dependency module in question.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.