Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CiHelper function checkPythonExec to use 'pip3 install --user' and improve error message #12097

Merged
merged 2 commits into from Sep 15, 2020
Merged

Fix CiHelper function checkPythonExec to use 'pip3 install --user' and improve error message #12097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7402f75
Fix pip3 install function to use --user
damonreed Sep 15, 2020
fbb96d5
Update error message to reflect somethign closer to reality.
damonreed Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions LibreNMS/Util/CiHelper.php
View file
Open in desktop
Expand Up @@ -491,13 +491,15 @@ private function checkPythonExec($exec)
}

echo "Running pip3 install to install developer dependencies.\n";
passthru("pip3 install $exec"); // probably wrong in other cases...
passthru("pip3 install --user $exec"); // probably wrong in other cases...

if (is_executable($path)) {
return $path;
}

echo "\nRunning installing deps with pip3 failed.\n You should try running 'pip3 install -r requirements.txt' by hand\n";
echo "\nRunning installing deps with pip3 failed.\n You should try running 'pip3 install --user ";
echo $exec;
echo "' by hand\n";
echo "You can find more info at http://docs.librenms.org/Developing/Validating-Code/\n";
exit(1);
}
Expand Down