Update Install-LibreNMS.md #12201
Merged
Update Install-LibreNMS.md #12201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the symbol for comments from # to ; This threw an error for me while following the steps and had to google to fix the issue. Changing to ; might help people like me who are new to php. Not sure if it would affect any older versions.
|
|
|
Interesting, I didn't consider that people would copy those lines :D |
|
Haha, people who have absolutely no knowledge of php like me would 😁
…On Fri, 9 Oct 2020 at 6:18 PM, Tony Murray ***@***.***> wrote:
Interesting, I didn't consider that people would copy those lines :D
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12201 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKS6NBUP53GRRPYK7FFAUL3SJ4BANANCNFSM4SIUUK4A>
.
|
|
Anything that makes it easier is appreciated, thanks. |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/v1-69-release-changelog-october-2020/13837/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the symbol for comments from # to ;
This threw an error for me while following the steps and had to google to fix the issue. Changing to ; might help people like me who are new to php. Not sure if it would affect any older versions.
Please give a short description what your pull request is for
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.