Add support for new Extreme VSP/VOSS models

[ospfbgp]

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[ospfbgp]

Adding support for some legacy VSP models and new VSP4900 and 5520 series. All of the models use the same kernel so no need to add snmpsim data for these. They all use the same OID for fans, power supplies, cpu, memory, vlans and etc... There is already many VSP models in the snmpsim. I do not have access to test all these models but I have verified oids from manufacture.

[murrant]

Ok, I looked at the reported stats and:
voss: .1.3.6.1.4.1.2272 /^VSP-/
boss: .1.3.6.1.4.1.2272 /^ERS-/
xos: .1.3.6.1.4.1.1916.2

Why are we calling out specific models? (which requires constant updates)

[murrant]

Ok, how about this for generic style detection?

boss

discovery:
    -
        sysObjectID:
            - .1.3.6.1.4.1.45.
            - .1.3.6.1.4.1.2272.
        sysDescr:
            - 'Ethernet Switch'
            - 'Ethernet Routing Switch'
            - 'ERS'
            - 'Virtual Services Platform 7024XLS'
            - 'Virtual Services Platform 7024XT'

voss

discovery:
    -
        sysObjectID:
            - .1.3.6.1.4.1.2272. # everything not caught by boss OS
    -
        sysObjectID:
            - .1.3.6.1.4.1.1916.2.
        sysDescr:
            - VSP
            - VOSS
            - XA1440
            - XA1480

xos

discovery:
    -
        sysObjectID:
            - .1.3.6.1.4.1.1916.2. # everything not caught by voss OS

[ospfbgp]

Ok, how about this for generic style detection?

boss

discovery:
    -
        sysObjectID:
            - .1.3.6.1.4.1.45.
            - .1.3.6.1.4.1.2272.
        sysDescr:
            - 'Ethernet Switch'
            - 'Ethernet Routing Switch'
            - 'ERS'
            - 'Virtual Services Platform 7024XLS'
            - 'Virtual Services Platform 7024XT'

voss

discovery:
    -
        sysObjectID:
            - .1.3.6.1.4.1.2272. # everything not caught by boss OS
    -
        sysObjectID:
            - .1.3.6.1.4.1.1916.2.
        sysDescr:
            - VSP
            - VOSS
            - XA1440
            - XA1480

xos

discovery:
    -
        sysObjectID:
            - .1.3.6.1.4.1.1916.2. # everything not caught by voss OS

Let me test this in my lab. :-) This is a pain because they moved oid on voss from one prefix to the next. I understand what you are saying. Let me do some testing.

[ospfbgp]

I have have cleaned up the yaml file and took your recommendation. I did testing and devices were discovering properly. For BOSS and VOSS.

[ospfbgp]

This should be complete. I deleted several BOSS, VOSS and EXOS in my lab and added back. Discovery of the OS was correct for each platform. Thank you Murrant for the logic. This will allow future VSP to work without making special exceptions.

[murrant]

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-69-release-changelog-november-2020/14124/1