-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce word wrapping to the custom login message #12460
Reintroduce word wrapping to the custom login message #12460
Conversation
The <pre> tag breaks the well formed output of the login messages by introducing scrollbars and wrong background color. Later is most noticeable in the dark theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@efelon this breaks line returns in the message |
@murrant Can you give me more details how you entered the new lines? What I have done is to check the "General Authentication Settings" input field for "Logon Message". There you don't have the possibility to enter new lines. After your comment I tried also: |
@efelon Like this:
That is why it was changed to a pre tag a couple of releases ago ;) If you want both, you will need to have use nl2br and html purifier to allow only br (and maybe a few select other) tags. |
@murrant I see, my bad. I haven't checked the option in the configuration config.php:
Let me see if I can find a solution otherwise I will make a new PR reverting the change. |
Introducing own css class for customization Fix problem introduced with librenms#12460
Introducing own css class for customization Fix problem introduced with #12460
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
The <pre> tag breaks the well formed output of the login messages by introducing scrollbars and wrong background color. Later is most noticeable in the dark theme.
Just by using div instead of pre fixes the output.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.