Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct OID for c3GsmSimStatus #12724

Merged
merged 4 commits into from
Apr 8, 2021
Merged

Conversation

tamikkelsen
Copy link
Contributor

Wrong OID used for c3GsmSimStatus

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Wrong OID used for c3GsmSimStatus
@Jellyfrog Jellyfrog added Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Apr 8, 2021
@label-actions
Copy link

label-actions bot commented Apr 8, 2021

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@Jellyfrog
Copy link
Member

Thanks

You need to update the test files accordingly also, see the broken tests below

@Jellyfrog Jellyfrog changed the title Update cisco.inc.php Correct OID for c3GsmSimStatus Apr 8, 2021
@PipoCanaja
Copy link
Contributor

Hi @tamikkelsen
Seems that your commit ended up empty. I corrected the test data, and automatic regression tests should succeed now.
Thanx for your contribution

PipoCanaja
PipoCanaja previously approved these changes Apr 8, 2021
murrant
murrant previously approved these changes Apr 8, 2021
@PipoCanaja PipoCanaja dismissed stale reviews from murrant and themself via 88b7786 April 8, 2021 16:11
@PipoCanaja PipoCanaja added Bug 🕷️ and removed Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Apr 8, 2021
@PipoCanaja PipoCanaja merged commit 8eda073 into librenms:master Apr 8, 2021
@Cupidazul Cupidazul mentioned this pull request Apr 16, 2021
2 tasks
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/21-4-0-changelog/15528/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🕷️ Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants