WIP - Rewrite Wireless Controller polling

[ottorei]

Modernize old code for wireless controllers polling. Work in progress.

TODO:

• Update web-page to allow the use of the new module
• Update all database queries to Eloquent in the poller module
• Implement poller functions for Aruba WLC-devices
• Implement poller functions for Cisco WLC-devices
• Implement poller functions for VRP WLC-devices
• Implement syncmodels for DB
• Save WLC and AP RRD-data
• Automatic cleanup option, user configurable
• Existing alerting breaks for deleted access points with this, figure out something

Notice: Each AP is uniquely distinguished by it's MAC-address + radionumber. This should work for most devices and would allow the AP to be moved to another controller without issues on the NMS.

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 13198
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[murrant]

@ottorei Excited to see this, let us know if you have any questions :D

[ottorei]

I am having some issues with the syncmodel as for some reason it can not sync on dev machine. I think this has something do to with the DB being empty.

Call to a member function getCompositeKey() on null
{"exception":"[object] (Error(code: 0):
Call to a member function getCompositeKey() on null at /opt/librenms/LibreNMS/DB/SyncsModels.php:43)"}

[murrant]

https://laravel.com/docs/8.x/eloquent#soft-deleting

[ottorei]

With this implemented, I would just need to use withThrashed to get all aps?

[murrant]

@ottorei correct

[murrant]

and it stores the deleted date, so we can do a cleanup.

[ottorei]

and it stores the deleted date, so we can do a cleanup.

Yes, with a user configurable amount of days.

[ottorei]

I am having some issues with the syncmodel as for some reason it can not sync on dev machine. I think this has something do to with the DB being empty.

Call to a member function getCompositeKey() on null
{"exception":"[object] (Error(code: 0):
Call to a member function getCompositeKey() on null at /opt/librenms/LibreNMS/DB/SyncsModels.php:43)"}

With the latest commit, APs can now be saved and the error message is no longer present after polling.

[ottorei]

@ottorei what do you need to continue with this?

Would need to convert the existing wireless controllers code use this new module. The Aruba one seems to be working to some extent but I have not started the work with others yet.

[Jellyfrog]

(Rerunning tests)

[ottorei]

Converted the Cisco WLC to the new module. Not really tested yet.

[ottorei]

Still not quite sure what to do with the soft deleted models. The existing alert rules for "deleted" APs will break with this PR if the deleted-field is removed from the DB. What kind of approach should I take here to still allow users to make alert rules with the query builder for these @murrant ? A macro...?

[Jellyfrog]

Please note we got stricter php linting now, it's 99% about type hinting. But the tests will tell you what to do :)

[murrant]

Are you sure the existing rule will break? Type juggling might make them work still. Also, see #13480 to merge all files to one RRD scheme.

[ottorei]

Are you sure the existing rule will break? Type juggling might make them work still. Also, see #13480 to merge all files to one RRD scheme.

Yes, since the existing database column is named "deleted". But I remember that alert was not on the list of predefined rules.

[murrant]

@ottorei for alerting, we have in the past updated existing alert rules in the db.

[ottorei]

@ottorei for alerting, we have in the past updated existing alert rules in the db.

You mean the sample rules?

[murrant]

No, I mean direct in the database ;)