New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RRD Allow specifying a source file and ds to fill data #13480

Merged

murrant merged 3 commits into librenms:master from murrant:rrdcreate-source

Dec 6, 2021

Member

murrant commented Nov 5, 2021

This will allow migration of data from old files to new files

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

Have you followed our code guidelines?
If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.


          Allow specifying a source file and ds to fill data

83e8b61

murrant added the Feature label

murrant mentioned this pull request

WIP - Rewrite Wireless Controller polling #13198

Open

11 tasks

murrant added 2 commits

November 6, 2021 01:22


          Need to check if rrd file exists, so delay processing until __toString

fdd25ac


          Update RrdDefinition.php

33f783a

murrant marked this pull request as ready for review

November 12, 2021 19:29

murrant mentioned this pull request

Don't hardcode index for Mikrotik LTE wireless statistics #12976

Merged

2 tasks

murrant merged commit 29328b2 into librenms:master

murrant deleted the rrdcreate-source branch

December 6, 2021 14:05

murrant mentioned this pull request

Add Sla jitter packet loss percent graph #13600

Merged

3 tasks

murrant restored the rrdcreate-source branch

December 6, 2021 18:34

murrant added a commit that referenced this pull request


          Revert "RRD Allow specifying a source file and ds to fill data (#13480)"

5879e1b

This reverts commit 29328b2.

murrant mentioned this pull request

Revert "RRD Allow specifying a source file and ds to fill data" #13602

Merged

murrant added a commit that referenced this pull request


          Revert "RRD Allow specifying a source file and ds to fill data (#13480)…

a046420

…" (#13602)

This reverts commit 29328b2.

eskyuu pushed a commit to eskyuu/librenms that referenced this pull request


          RRD Allow specifying a source file and ds to fill data (librenms#13480)

de1c9b7

* Allow specifying a source file and ds to fill data

* Need to check if rrd file exists, so delay processing until __toString

* Update RrdDefinition.php

eskyuu pushed a commit to eskyuu/librenms that referenced this pull request


          Revert "RRD Allow specifying a source file and ds to fill data (libre…

cbfdc39

…nms#13480)" (librenms#13602)

This reverts commit 29328b2.

librenms-bot commented Dec 22, 2021

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/21-12-0-changelog/17740/1

NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request


          RRD Allow specifying a source file and ds to fill data (librenms#13480)

5f08a61

* Allow specifying a source file and ds to fill data

* Need to check if rrd file exists, so delay processing until __toString

* Update RrdDefinition.php

NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request


          Revert "RRD Allow specifying a source file and ds to fill data (libre…

502a845

…nms#13480)" (librenms#13602)

This reverts commit 29328b2.

NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request


          RRD Allow specifying a source file and ds to fill data (librenms#13480)

f439d4d

* Allow specifying a source file and ds to fill data

* Need to check if rrd file exists, so delay processing until __toString

* Update RrdDefinition.php

NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request


          Revert "RRD Allow specifying a source file and ds to fill data (libre…

f1142a3

…nms#13480)" (librenms#13602)

This reverts commit 29328b2.

NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request


          RRD Allow specifying a source file and ds to fill data (librenms#13480)

a1d1441

* Allow specifying a source file and ds to fill data

* Need to check if rrd file exists, so delay processing until __toString

* Update RrdDefinition.php

NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request


          Revert "RRD Allow specifying a source file and ds to fill data (libre…

0e0a760

…nms#13480)" (librenms#13602)

This reverts commit 29328b2.

NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request


          RRD Allow specifying a source file and ds to fill data (librenms#13480)

ed88f8e

* Allow specifying a source file and ds to fill data

* Need to check if rrd file exists, so delay processing until __toString

* Update RrdDefinition.php

NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request


          Revert "RRD Allow specifying a source file and ds to fill data (libre…

e70b00f

…nms#13480)" (librenms#13602)

This reverts commit 29328b2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels