Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iDrac physical disk state #13264

Merged
merged 3 commits into from Nov 2, 2021

Conversation

tuxgasy
Copy link
Contributor

@tuxgasy tuxgasy commented Sep 22, 2021

Add iDrac physical disk state after discovery.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2021

CLA assistant check
All committers have signed the CLA.

@murrant murrant added Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Sep 23, 2021
@label-actions
Copy link

label-actions bot commented Sep 23, 2021

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@murrant
Copy link
Member

murrant commented Sep 23, 2021

Any chance you could add this in yaml instead? https://docs.librenms.org/Developing/os/Health-Information/
Also, some test data to make sure it doesn't get broken in the future is required.

@murrant murrant added the User-Pending Currently waiting for user response label Oct 6, 2021
Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add test data to this PR. You can add test data by following the test documentation.
Short version:
./scripts/collect-snmp-data.php -h <hostname>
./scripts/save-test-data.php -o <os> -v <unique variant name>

@tuxgasy
Copy link
Contributor Author

tuxgasy commented Oct 29, 2021

Thanks for your feedback @murrant

I will try to do it next week.

@murrant murrant removed Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ User-Pending Currently waiting for user response labels Nov 2, 2021
@Jellyfrog Jellyfrog merged commit e044329 into librenms:master Nov 2, 2021
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/21-11-0-changelog/17383/1

NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request Dec 30, 2021
* Add physical disk for iDrac

* Add alert rule for iDrac Physical Disk

* Add test data
NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request Dec 30, 2021
* Add physical disk for iDrac

* Add alert rule for iDrac Physical Disk

* Add test data
NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request Dec 31, 2021
* Add physical disk for iDrac

* Add alert rule for iDrac Physical Disk

* Add test data
NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request Dec 31, 2021
* Add physical disk for iDrac

* Add alert rule for iDrac Physical Disk

* Add test data
@tuxgasy tuxgasy deleted the iDrac-physicalDiskState branch June 11, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants