-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iDrac physical disk state #13264
Conversation
4d97408
to
48f43a9
Compare
Please add test data so we can ensure your change is not broken in the future. Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units |
Any chance you could add this in yaml instead? https://docs.librenms.org/Developing/os/Health-Information/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add test data to this PR. You can add test data by following the test documentation.
Short version:
./scripts/collect-snmp-data.php -h <hostname>
./scripts/save-test-data.php -o <os> -v <unique variant name>
Thanks for your feedback @murrant I will try to do it next week. |
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
* Add physical disk for iDrac * Add alert rule for iDrac Physical Disk * Add test data
* Add physical disk for iDrac * Add alert rule for iDrac Physical Disk * Add test data
* Add physical disk for iDrac * Add alert rule for iDrac Physical Disk * Add test data
* Add physical disk for iDrac * Add alert rule for iDrac Physical Disk * Add test data
Add iDrac physical disk state after discovery.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.