Fix python config fetch disrupted by stderr output #13295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea how to make command_runner not include debug output, so just use subprocess.check_output
|
@deajan Any ideas on this one? |
|
Enable the snmp module in php and set |
|
@deajan merging this in the meantime. |
|
No problem. Will give me more time to investigate. Sorry for the noise again, that PR was a major headache ;) |
2 tasks
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
eskyuu
pushed a commit
to eskyuu/librenms
that referenced
this pull request
Oct 21, 2021
* Fix python config fetch disrupted by stderr output I have no idea how to make command_runner not include debug output, so just use subprocess.check_output * restore import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea how to make command_runner not include debug output, so just use subprocess.check_output
Please give a short description what your pull request is for
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.