fix: Add consistent output of name and app_id to Poller for all Applications (fixes #13641)

[westerterp]

This PR fixes not only #13641, but standardizes the way the output of each Application polling starts.
Each Application will now first output the Application name and app_id before any application-specific output starts.

Every Application has been checked. There was quite some inconsistency.

• If no echo statement was found, it was added
• Some Applications only printed the name, but not the app_id, the app_id's have been added to the echo
• The echo now always uses the $name variable and not hardcoded values
• The use of d_echo debug function was removed.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
• If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[CLAassistant]

All committers have signed the CLA.

[murrant]

I like the idea, but wouldn't it be better to output this in applications.inc.php so we don't have to modify every application?

[westerterp]

Thanks for the suggestion!
That would make a lot more sense indeed.
Although if we do that, we won't have access to the Application name, but this was solved by using the app_type from the database

[laf]

LGTM

[librenms-bot]

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/22-1-0-changelog/17974/1