Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix luminato port poll #14217

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Fix luminato port poll #14217

merged 3 commits into from
Aug 19, 2022

Conversation

murrant
Copy link
Member

@murrant murrant commented Aug 19, 2022

I still don't like it, but this improves the code consistency a bit.

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

I still don't like it, but this improves the code consistency a bit.
@murrant murrant added Bug 🕷️ Device 🖥️ New or added device support labels Aug 19, 2022
@murrant murrant merged commit d2a692c into librenms:master Aug 19, 2022
@murrant murrant deleted the fix-luminato branch August 19, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🕷️ Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant