Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port pages fixes and cleanups #14310

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Port pages fixes and cleanups #14310

merged 2 commits into from
Sep 7, 2022

Conversation

murrant
Copy link
Member

@murrant murrant commented Sep 6, 2022

Fix mac display on device port page
Move ports query building into the graph page where it is used
Add the filter ui to the all ports graphs pages

fixes: #14308

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix mac display on device port page
Move ports query building into the graph page where it is used
Add the filter ui to the all ports graphs pages
@Jellyfrog Jellyfrog closed this Sep 6, 2022
@Jellyfrog Jellyfrog reopened this Sep 6, 2022
@murrant murrant merged commit ae15c8e into librenms:master Sep 7, 2022
@murrant murrant deleted the ports-fixes branch September 7, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac address formatted incorrectly on device port page
2 participants