Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for additional Moxa EDS-G models #14405

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

rhinoau
Copy link
Contributor

@rhinoau rhinoau commented Sep 29, 2022

Support for additional Moxa EDS-G units G512E and G516E

From the limited test data on the existing models it's hard to confirm others but it looks like IKS and EDSP serialNumber lines were breaking some discovery items for all models with exit 1 - removed. Both MIBs do not include such an entry.

Discovery debug output:

Exitcode: 1  

MOXA-IKS6726A-MIB::serialNumber: Unknown Object Identifier
MOXA-EDSP510A8POE-MIB::serialNumber: Unknown Object Identifier  

image

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@rhinoau rhinoau changed the title Moxa eds Added support for additional Moxa EDS-G models Sep 29, 2022
@PipoCanaja
Copy link
Contributor

LGTM

@Jellyfrog Jellyfrog merged commit b8b4b8e into librenms:master Oct 7, 2022
@rhinoau rhinoau deleted the moxa-eds branch October 13, 2022 06:23
@murrant murrant added the Device 🖥️ New or added device support label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants