Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange AD auth settings #15363

Merged
merged 1 commit into from Oct 4, 2023
Merged

Conversation

murrant
Copy link
Member

@murrant murrant commented Sep 29, 2023

so it makes more sense, add missing settings

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

so it makes more sense, add missing settings
@electrocret electrocret closed this Oct 3, 2023
@electrocret electrocret reopened this Oct 3, 2023
@murrant murrant merged commit c6d8159 into librenms:master Oct 4, 2023
12 of 14 checks passed
@murrant murrant deleted the ad-config-refactor branch October 4, 2023 07:08
MrShunz pushed a commit to MrShunz/librenms that referenced this pull request Oct 4, 2023
so it makes more sense, add missing settings
murrant added a commit that referenced this pull request Oct 4, 2023
* Add useful IF-MIB entries as 'unordered oids'
to Raisecom ROS and ROAP definitions because
they don't have increasing OIDs in snmpwalk

* Bump composer/composer from 2.5.8 to 2.6.4 (#15364)

Bumps [composer/composer](https://github.com/composer/composer) from 2.5.8 to 2.6.4.
- [Release notes](https://github.com/composer/composer/releases)
- [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md)
- [Commits](composer/composer@2.5.8...2.6.4)

---
updated-dependencies:
- dependency-name: composer/composer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update aviat-wtm.json (#15368)

* sort services by type and name (#15367)

* Added support for Cambium cnMatrix switches (#15351)

* Added support for Cambium cnMatrix switches

* Fixed styling issues

* Fixed styling issues

* Fixed duplicate, incorrectly labeled LLDP-EXT-DOT3-MIB and LLDP-EXT-DOT1-MIB

* Corrected MIB with the same name but with different OIDs configured: LLDP-EXT-MED/-CAMBIUM/-MIB

* Removed my added duplicate MIBs

* Removed unused MIBs

* Rearrange AD auth settings (#15363)

so it makes more sense, add missing settings

* Specify radius attributes for auth roles (#15374)

* Specify radius attributes for auth roles

* Clarify that any role can be defined

* Fixes check_dns against localhost when a search-domain is configured (#15373)

* Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (#15372)

* Moxa EDS improve discovery (#15375)

Consolidate walks so less need to be performed.
This should help a lot since each device model has its own MIB.

* Remove unused functions (#15371)

* Remove unused functions
inline other legacy functions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

* Availability module fixes (#15369)

* Refactor poller to allow modules to run even if the device is down
Include core in config (but not webui) to avoid silly shenanigans
Inject datastore into polling

* Needed to split datastore interface

* Cleanup some data_udpate() references

* Apply fixes from StyleCI

* Fix legacy poller :D

* Output to the correct stream

* Fix lint issues

* Apply fixes from StyleCI

* Fix discovery not including core and submodule handling

* Use whereRaw

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Lentz <monkeybrains7@gmail.com>
Co-authored-by: SourceDoctor <sourcehhdoctor@googlemail.com>
Co-authored-by: Noah Roufus <noaheroufus@gmail.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: barryodonovan <barry.odonovan@lightnet.ie>
Co-authored-by: Tim de Boer <tim@tim427.net>
Co-authored-by: StyleCI Bot <bot@styleci.io>
peejaychilds pushed a commit to peejaychilds/librenms that referenced this pull request Oct 26, 2023
so it makes more sense, add missing settings
peejaychilds pushed a commit to peejaychilds/librenms that referenced this pull request Oct 26, 2023
…#15365)

* Add useful IF-MIB entries as 'unordered oids'
to Raisecom ROS and ROAP definitions because
they don't have increasing OIDs in snmpwalk

* Bump composer/composer from 2.5.8 to 2.6.4 (librenms#15364)

Bumps [composer/composer](https://github.com/composer/composer) from 2.5.8 to 2.6.4.
- [Release notes](https://github.com/composer/composer/releases)
- [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md)
- [Commits](composer/composer@2.5.8...2.6.4)

---
updated-dependencies:
- dependency-name: composer/composer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update aviat-wtm.json (librenms#15368)

* sort services by type and name (librenms#15367)

* Added support for Cambium cnMatrix switches (librenms#15351)

* Added support for Cambium cnMatrix switches

* Fixed styling issues

* Fixed styling issues

* Fixed duplicate, incorrectly labeled LLDP-EXT-DOT3-MIB and LLDP-EXT-DOT1-MIB

* Corrected MIB with the same name but with different OIDs configured: LLDP-EXT-MED/-CAMBIUM/-MIB

* Removed my added duplicate MIBs

* Removed unused MIBs

* Rearrange AD auth settings (librenms#15363)

so it makes more sense, add missing settings

* Specify radius attributes for auth roles (librenms#15374)

* Specify radius attributes for auth roles

* Clarify that any role can be defined

* Fixes check_dns against localhost when a search-domain is configured (librenms#15373)

* Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (librenms#15372)

* Moxa EDS improve discovery (librenms#15375)

Consolidate walks so less need to be performed.
This should help a lot since each device model has its own MIB.

* Remove unused functions (librenms#15371)

* Remove unused functions
inline other legacy functions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

* Availability module fixes (librenms#15369)

* Refactor poller to allow modules to run even if the device is down
Include core in config (but not webui) to avoid silly shenanigans
Inject datastore into polling

* Needed to split datastore interface

* Cleanup some data_udpate() references

* Apply fixes from StyleCI

* Fix legacy poller :D

* Output to the correct stream

* Fix lint issues

* Apply fixes from StyleCI

* Fix discovery not including core and submodule handling

* Use whereRaw

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Lentz <monkeybrains7@gmail.com>
Co-authored-by: SourceDoctor <sourcehhdoctor@googlemail.com>
Co-authored-by: Noah Roufus <noaheroufus@gmail.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: barryodonovan <barry.odonovan@lightnet.ie>
Co-authored-by: Tim de Boer <tim@tim427.net>
Co-authored-by: StyleCI Bot <bot@styleci.io>
gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
so it makes more sense, add missing settings
gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
…#15365)

* Add useful IF-MIB entries as 'unordered oids'
to Raisecom ROS and ROAP definitions because
they don't have increasing OIDs in snmpwalk

* Bump composer/composer from 2.5.8 to 2.6.4 (librenms#15364)

Bumps [composer/composer](https://github.com/composer/composer) from 2.5.8 to 2.6.4.
- [Release notes](https://github.com/composer/composer/releases)
- [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md)
- [Commits](composer/composer@2.5.8...2.6.4)

---
updated-dependencies:
- dependency-name: composer/composer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update aviat-wtm.json (librenms#15368)

* sort services by type and name (librenms#15367)

* Added support for Cambium cnMatrix switches (librenms#15351)

* Added support for Cambium cnMatrix switches

* Fixed styling issues

* Fixed styling issues

* Fixed duplicate, incorrectly labeled LLDP-EXT-DOT3-MIB and LLDP-EXT-DOT1-MIB

* Corrected MIB with the same name but with different OIDs configured: LLDP-EXT-MED/-CAMBIUM/-MIB

* Removed my added duplicate MIBs

* Removed unused MIBs

* Rearrange AD auth settings (librenms#15363)

so it makes more sense, add missing settings

* Specify radius attributes for auth roles (librenms#15374)

* Specify radius attributes for auth roles

* Clarify that any role can be defined

* Fixes check_dns against localhost when a search-domain is configured (librenms#15373)

* Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (librenms#15372)

* Moxa EDS improve discovery (librenms#15375)

Consolidate walks so less need to be performed.
This should help a lot since each device model has its own MIB.

* Remove unused functions (librenms#15371)

* Remove unused functions
inline other legacy functions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

* Availability module fixes (librenms#15369)

* Refactor poller to allow modules to run even if the device is down
Include core in config (but not webui) to avoid silly shenanigans
Inject datastore into polling

* Needed to split datastore interface

* Cleanup some data_udpate() references

* Apply fixes from StyleCI

* Fix legacy poller :D

* Output to the correct stream

* Fix lint issues

* Apply fixes from StyleCI

* Fix discovery not including core and submodule handling

* Use whereRaw

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Lentz <monkeybrains7@gmail.com>
Co-authored-by: SourceDoctor <sourcehhdoctor@googlemail.com>
Co-authored-by: Noah Roufus <noaheroufus@gmail.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: barryodonovan <barry.odonovan@lightnet.ie>
Co-authored-by: Tim de Boer <tim@tim427.net>
Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants