Specify radius attributes for auth roles by barryodonovan · Pull Request #15374 · librenms/librenms

barryodonovan · 2023-10-04T09:53:28Z

Add back to documentation the accepted radius attribute vales for each role.

I implemented this yesterday and could only find the appropriate values by reading back through the commit logs to their removal.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

Have you followed our code guidelines?
If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

murrant · 2023-10-04T13:47:50Z

Hi, the reason they were removed is because there are no fixed roles. It could be anything. It might make sense to add them back with context that they are the built in roles and any role name can be set.

barryodonovan · 2023-10-04T14:09:18Z

I've added a clarification that these are the built-in roles but that any role name can be passed. I'm on monthly so haven't seen full RBAC implementation, I will update docs again if required once I've used the feature.

murrant

Looks great, thanks!

murrant · 2023-10-04T14:10:40Z

RBAC is implemented, but no management ui exists yet :)

barryodonovan · 2023-10-04T14:12:34Z

I'll look at using what's there but don't think UI is in my skillset!

murrant · 2023-10-04T15:12:24Z

The items:

figure out how collect a list of all permissions (probably just in a json file)
add a ui to create roles and assign permissions to roles
possibly allow permissions added directly to users, (unsure)

* Specify radius attributes for auth roles * Clarify that any role can be defined

* Add useful IF-MIB entries as 'unordered oids' to Raisecom ROS and ROAP definitions because they don't have increasing OIDs in snmpwalk * Bump composer/composer from 2.5.8 to 2.6.4 (#15364) Bumps [composer/composer](https://github.com/composer/composer) from 2.5.8 to 2.6.4. - [Release notes](https://github.com/composer/composer/releases) - [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md) - [Commits](composer/composer@2.5.8...2.6.4) --- updated-dependencies: - dependency-name: composer/composer dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update aviat-wtm.json (#15368) * sort services by type and name (#15367) * Added support for Cambium cnMatrix switches (#15351) * Added support for Cambium cnMatrix switches * Fixed styling issues * Fixed styling issues * Fixed duplicate, incorrectly labeled LLDP-EXT-DOT3-MIB and LLDP-EXT-DOT1-MIB * Corrected MIB with the same name but with different OIDs configured: LLDP-EXT-MED/-CAMBIUM/-MIB * Removed my added duplicate MIBs * Removed unused MIBs * Rearrange AD auth settings (#15363) so it makes more sense, add missing settings * Specify radius attributes for auth roles (#15374) * Specify radius attributes for auth roles * Clarify that any role can be defined * Fixes check_dns against localhost when a search-domain is configured (#15373) * Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (#15372) * Moxa EDS improve discovery (#15375) Consolidate walks so less need to be performed. This should help a lot since each device model has its own MIB. * Remove unused functions (#15371) * Remove unused functions inline other legacy functions * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io> * Availability module fixes (#15369) * Refactor poller to allow modules to run even if the device is down Include core in config (but not webui) to avoid silly shenanigans Inject datastore into polling * Needed to split datastore interface * Cleanup some data_udpate() references * Apply fixes from StyleCI * Fix legacy poller :D * Output to the correct stream * Fix lint issues * Apply fixes from StyleCI * Fix discovery not including core and submodule handling * Use whereRaw --------- Co-authored-by: StyleCI Bot <bot@styleci.io> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justin Lentz <monkeybrains7@gmail.com> Co-authored-by: SourceDoctor <sourcehhdoctor@googlemail.com> Co-authored-by: Noah Roufus <noaheroufus@gmail.com> Co-authored-by: Tony Murray <murraytony@gmail.com> Co-authored-by: barryodonovan <barry.odonovan@lightnet.ie> Co-authored-by: Tim de Boer <tim@tim427.net> Co-authored-by: StyleCI Bot <bot@styleci.io>

* Specify radius attributes for auth roles * Clarify that any role can be defined

…#15365) * Add useful IF-MIB entries as 'unordered oids' to Raisecom ROS and ROAP definitions because they don't have increasing OIDs in snmpwalk * Bump composer/composer from 2.5.8 to 2.6.4 (librenms#15364) Bumps [composer/composer](https://github.com/composer/composer) from 2.5.8 to 2.6.4. - [Release notes](https://github.com/composer/composer/releases) - [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md) - [Commits](composer/composer@2.5.8...2.6.4) --- updated-dependencies: - dependency-name: composer/composer dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update aviat-wtm.json (librenms#15368) * sort services by type and name (librenms#15367) * Added support for Cambium cnMatrix switches (librenms#15351) * Added support for Cambium cnMatrix switches * Fixed styling issues * Fixed styling issues * Fixed duplicate, incorrectly labeled LLDP-EXT-DOT3-MIB and LLDP-EXT-DOT1-MIB * Corrected MIB with the same name but with different OIDs configured: LLDP-EXT-MED/-CAMBIUM/-MIB * Removed my added duplicate MIBs * Removed unused MIBs * Rearrange AD auth settings (librenms#15363) so it makes more sense, add missing settings * Specify radius attributes for auth roles (librenms#15374) * Specify radius attributes for auth roles * Clarify that any role can be defined * Fixes check_dns against localhost when a search-domain is configured (librenms#15373) * Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (librenms#15372) * Moxa EDS improve discovery (librenms#15375) Consolidate walks so less need to be performed. This should help a lot since each device model has its own MIB. * Remove unused functions (librenms#15371) * Remove unused functions inline other legacy functions * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io> * Availability module fixes (librenms#15369) * Refactor poller to allow modules to run even if the device is down Include core in config (but not webui) to avoid silly shenanigans Inject datastore into polling * Needed to split datastore interface * Cleanup some data_udpate() references * Apply fixes from StyleCI * Fix legacy poller :D * Output to the correct stream * Fix lint issues * Apply fixes from StyleCI * Fix discovery not including core and submodule handling * Use whereRaw --------- Co-authored-by: StyleCI Bot <bot@styleci.io> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justin Lentz <monkeybrains7@gmail.com> Co-authored-by: SourceDoctor <sourcehhdoctor@googlemail.com> Co-authored-by: Noah Roufus <noaheroufus@gmail.com> Co-authored-by: Tony Murray <murraytony@gmail.com> Co-authored-by: barryodonovan <barry.odonovan@lightnet.ie> Co-authored-by: Tim de Boer <tim@tim427.net> Co-authored-by: StyleCI Bot <bot@styleci.io>

* Specify radius attributes for auth roles * Clarify that any role can be defined

…#15365) * Add useful IF-MIB entries as 'unordered oids' to Raisecom ROS and ROAP definitions because they don't have increasing OIDs in snmpwalk * Bump composer/composer from 2.5.8 to 2.6.4 (librenms#15364) Bumps [composer/composer](https://github.com/composer/composer) from 2.5.8 to 2.6.4. - [Release notes](https://github.com/composer/composer/releases) - [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md) - [Commits](composer/composer@2.5.8...2.6.4) --- updated-dependencies: - dependency-name: composer/composer dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update aviat-wtm.json (librenms#15368) * sort services by type and name (librenms#15367) * Added support for Cambium cnMatrix switches (librenms#15351) * Added support for Cambium cnMatrix switches * Fixed styling issues * Fixed styling issues * Fixed duplicate, incorrectly labeled LLDP-EXT-DOT3-MIB and LLDP-EXT-DOT1-MIB * Corrected MIB with the same name but with different OIDs configured: LLDP-EXT-MED/-CAMBIUM/-MIB * Removed my added duplicate MIBs * Removed unused MIBs * Rearrange AD auth settings (librenms#15363) so it makes more sense, add missing settings * Specify radius attributes for auth roles (librenms#15374) * Specify radius attributes for auth roles * Clarify that any role can be defined * Fixes check_dns against localhost when a search-domain is configured (librenms#15373) * Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (librenms#15372) * Moxa EDS improve discovery (librenms#15375) Consolidate walks so less need to be performed. This should help a lot since each device model has its own MIB. * Remove unused functions (librenms#15371) * Remove unused functions inline other legacy functions * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io> * Availability module fixes (librenms#15369) * Refactor poller to allow modules to run even if the device is down Include core in config (but not webui) to avoid silly shenanigans Inject datastore into polling * Needed to split datastore interface * Cleanup some data_udpate() references * Apply fixes from StyleCI * Fix legacy poller :D * Output to the correct stream * Fix lint issues * Apply fixes from StyleCI * Fix discovery not including core and submodule handling * Use whereRaw --------- Co-authored-by: StyleCI Bot <bot@styleci.io> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justin Lentz <monkeybrains7@gmail.com> Co-authored-by: SourceDoctor <sourcehhdoctor@googlemail.com> Co-authored-by: Noah Roufus <noaheroufus@gmail.com> Co-authored-by: Tony Murray <murraytony@gmail.com> Co-authored-by: barryodonovan <barry.odonovan@lightnet.ie> Co-authored-by: Tim de Boer <tim@tim427.net> Co-authored-by: StyleCI Bot <bot@styleci.io>

Specify radius attributes for auth roles

6c338c3

Clarify that any role can be defined

30435e3

murrant approved these changes Oct 4, 2023

View reviewed changes

murrant added the Documentation 📖 label Oct 4, 2023

murrant merged commit 529b721 into librenms:master Oct 4, 2023

barryodonovan deleted the radius_auth_docs branch October 4, 2023 14:12

MrShunz pushed a commit to MrShunz/librenms that referenced this pull request Oct 4, 2023

Specify radius attributes for auth roles (librenms#15374)

3effebf

* Specify radius attributes for auth roles * Clarify that any role can be defined

peejaychilds pushed a commit to peejaychilds/librenms that referenced this pull request Oct 26, 2023

Specify radius attributes for auth roles (librenms#15374)

854a4dc

* Specify radius attributes for auth roles * Clarify that any role can be defined

gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024

Specify radius attributes for auth roles (librenms#15374)

f8f7945

* Specify radius attributes for auth roles * Clarify that any role can be defined

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Specify radius attributes for auth roles#15374

Specify radius attributes for auth roles#15374
murrant merged 2 commits intolibrenms:masterfrom
barryodonovan:radius_auth_docs

barryodonovan commented Oct 4, 2023

Uh oh!

murrant commented Oct 4, 2023

Uh oh!

barryodonovan commented Oct 4, 2023

Uh oh!

murrant left a comment

Uh oh!

murrant commented Oct 4, 2023

Uh oh!

barryodonovan commented Oct 4, 2023

Uh oh!

murrant commented Oct 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

barryodonovan commented Oct 4, 2023

Please note

Testers

Uh oh!

murrant commented Oct 4, 2023

Uh oh!

barryodonovan commented Oct 4, 2023

Uh oh!

murrant left a comment

Choose a reason for hiding this comment

Uh oh!

murrant commented Oct 4, 2023

Uh oh!

barryodonovan commented Oct 4, 2023

Uh oh!

murrant commented Oct 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants