Pretty up Slack formatting. #15898
Merged
Pretty up Slack formatting. #15898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Normalize spaces by turning every instance of two or more spaces into one space. * Allow for custom URL links even when strip_tags() is in effect by transformaing "standard" markdown syntax into Slack link markdown after strip_tags() is run.
|
Here is a before and after screenshot of the formatting: Before: 
After: 
|
|
Perhaps a documentation update to mention the urls in markdown syntax would be good? |
While here, flesh out the Slack docs to match the configuration options one currently sees in the transport.
|
Document?! Don't we have people for that :-D . Good call. I added this bit about the links and fleshed out some other elements I thought were lacking. |
PipoCanaja
approved these changes
Mar 24, 2024
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.