Set config_name column in config table as a unique index #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around possible duplicates by keeping the first record.
| @@ -0,0 +1,5 @@ | |||
| CREATE TABLE tmp_table LIKE config; | |||
| ALTER IGNORE TABLE tmp_table ADD UNIQUE INDEX uniqueindex_configname (config_name); | |||
There was a problem hiding this comment.
Out of interest why the choice in name for this index?
There was a problem hiding this comment.
This is the name laravel picks when it creates indexes. It isn't needed here, I can drop it if you like. I put the name in because I was testing with the laravel schema and rollback.
There was a problem hiding this comment.
No it's fine, especially if it's from the Laravel stuff as I had to fix some issues with our schema build to port it over to Laravel so much prefer if it's right from day one.
laf
added a commit
that referenced
this pull request
Mar 22, 2016
Set config_name column in config table as a unique index
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around possible duplicates by keeping the first record.