Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear out stale alerts #6268

Merged
merged 1 commit into from
Mar 25, 2017
Merged

fix: Clear out stale alerts #6268

merged 1 commit into from
Mar 25, 2017

Conversation

laf
Copy link
Member

@laf laf commented Mar 24, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This removes alerts where the device_id in the alerts table can't find a matching entry in devices table.

@mention-bot
Copy link

Thank you for submitting a PR @laf! We have found the following @f0o, @murrant and @InsaneSplash based on the history of these files to review this PR.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6268.ci.librenms.org or https://6268.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: 1 updated code elements

Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No stale alerts on my install, but seems fine and doesn't break anything.

@laf laf merged commit af2930e into librenms:master Mar 25, 2017
@laf laf deleted the clear-stale-alerts branch March 25, 2017 21:02
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants