New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avaya VSP Temperature Support #6692

Merged
merged 13 commits into from May 31, 2017

Conversation

Projects
None yet
4 participants
@ospfbgp
Contributor

ospfbgp commented May 20, 2017

Avaya VSP Operating System Software Temperature Support

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Avaya VSP Temperature Support
Avaya VSP Operating System Software Temperature Support
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 20, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 20, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 20, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 20, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 20, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 20, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@ospfbgp

This comment has been minimized.

Show comment
Hide comment
@ospfbgp

ospfbgp May 20, 2017

Contributor

Code is complete and tested on multiple models of Avaya VSP.

Contributor

ospfbgp commented May 20, 2017

Code is complete and tested on multiple models of Avaya VSP.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 21, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@ospfbgp

This comment has been minimized.

Show comment
Hide comment
@ospfbgp

ospfbgp May 22, 2017

Contributor

I know that low limit just seems to get random numbers and so I just set it at 0 so that the graphs look uniform and you have a starting value to look at. I have had some issues with switches that were too hot. 55 is the upper end of what they can handle. I want to be alerted if anything hits 55 C. It seems to be the magic high limit for the vsp switches.

I will fix the code and make it like you say. It will take me a day or two and I want to test it in my lab.

Contributor

ospfbgp commented May 22, 2017

I know that low limit just seems to get random numbers and so I just set it at 0 so that the graphs look uniform and you have a starting value to look at. I have had some issues with switches that were too hot. 55 is the upper end of what they can handle. I want to be alerted if anything hits 55 C. It seems to be the magic high limit for the vsp switches.

I will fix the code and make it like you say. It will take me a day or two and I want to test it in my lab.

Update avaya-vsp.inc.php
New code for VSP Temperatures
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 23, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 23, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@ospfbgp

This comment has been minimized.

Show comment
Hide comment
@ospfbgp

ospfbgp May 23, 2017

Contributor

New code submitted. Hope it is up to the task. :-)

Contributor

ospfbgp commented May 23, 2017

New code submitted. Hope it is up to the task. :-)

Update avaya-vsp.inc.php
I have unset my 1 snmp_walk
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 24, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@laf

laf approved these changes May 31, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 31, 2017

Member

I've made some small changes, will merge once checks complete.

Member

laf commented May 31, 2017

I've made some small changes, will merge once checks complete.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented May 31, 2017

Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 31, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 31, 2017

The inspection completed: No new issues

@laf laf merged commit f8aadf2 into librenms:master May 31, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

Olen added a commit to Olen/librenms that referenced this pull request Jan 12, 2018

newdevice: Added Avaya VSP Temperature Support (#6692)
* Avaya VSP Temperature Support

Avaya VSP Operating System Software Temperature Support

* Update avaya-vsp.inc.php

* Update avaya-vsp.inc.php

* Update avaya-vsp.inc.php

* Update avaya-vsp.inc.php

* Update avaya-vsp.inc.php

* Update avaya-vsp.inc.php

* Update avaya-vsp.inc.php

* Update avaya-vsp.inc.php

New code for VSP Temperatures

* Update avaya-vsp.inc.php

* Update avaya-vsp.inc.php

I have unset my 1 snmp_walk

* small update to variable names and use
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.