Avaya VSP Temperature Support #6692
Conversation
Avaya VSP Operating System Software Temperature Support
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
|
Code is complete and tested on multiple models of Avaya VSP. |
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
| * the source code distribution for details. | ||
| */ | ||
|
|
||
| $high_limit = 55; |
There was a problem hiding this comment.
Why set hard limits? If the device doesn't provide them then we calculate the high / low limits.
| $low_limit = 0; | ||
|
|
||
| // rcChasFanAmbientTemperature | ||
| $tempsfan = snmp_walk($device, '.1.3.6.1.4.1.2272.1.4.7.1.1.3', '-Osqn'); |
There was a problem hiding this comment.
You should change your walks to use snmpwalk_cache_*, they provide the data in an array so you don't need to do explodes and things.
| default: | ||
| $var1 = "Unknown"; | ||
| } | ||
| } |
There was a problem hiding this comment.
Please unset() the two variables you've created from the walks so memory allocation is reduced slightly.
|
I know that low limit just seems to get random numbers and so I just set it at 0 so that the graphs look uniform and you have a starting value to look at. I have had some issues with switches that were too hot. 55 is the upper end of what they can handle. I want to be alerted if anything hits 55 C. It seems to be the magic high limit for the vsp switches. I will fix the code and make it like you say. It will take me a day or two and I want to test it in my lab. |
New code for VSP Temperatures
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
|
New code submitted. Hope it is up to the task. :-) |
I have unset my 1 snmp_walk
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
|
I've made some small changes, will merge once checks complete. |
|
Auto-Deploy finished, Test PR at http://6692.ci.librenms.org or https://6692.ci.librenms.org |
|
The inspection completed: No new issues |
* Avaya VSP Temperature Support Avaya VSP Operating System Software Temperature Support * Update avaya-vsp.inc.php * Update avaya-vsp.inc.php * Update avaya-vsp.inc.php * Update avaya-vsp.inc.php * Update avaya-vsp.inc.php * Update avaya-vsp.inc.php * Update avaya-vsp.inc.php * Update avaya-vsp.inc.php New code for VSP Temperatures * Update avaya-vsp.inc.php * Update avaya-vsp.inc.php I have unset my 1 snmp_walk * small update to variable names and use
|
This thread has been automatically locked since there has not been any recent activity after it was closed. |
Avaya VSP Operating System Software Temperature Support
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926