Add state support FAN, Power Supply Avaya VSP #6693
Conversation
Adding FAN and Power Supply support for Avaya VOSS(VSP operating systems platform)
|
Auto-Deploy finished, Test PR at http://6693.ci.librenms.org or https://6693.ci.librenms.org |
|
Auto-Deploy finished, Test PR at http://6693.ci.librenms.org or https://6693.ci.librenms.org |
| } | ||
| } | ||
|
|
||
| discover_sensor($valid['sensor'], 'state', $device, $current_oid, $index, $state_name, $descr, '1', '1', null, null, '3', '3', $state); |
There was a problem hiding this comment.
If $index is just single digits then it will conflict with the next state discovery.
Better to use "rcChasFanOperStatus.$index" in the discover_sensor() call. Same for below.
$index has been changed to rcChasFanOperStatus.$index and rcChasPowerSupplyOperStatus.$index in discover_sensor and create_sensor_to_state_index
|
Auto-Deploy finished, Test PR at http://6693.ci.librenms.org or https://6693.ci.librenms.org |
| } | ||
| } | ||
|
|
||
| discover_sensor($valid['sensor'], 'state', $device, $current_oid, rcChasFanOperStatus.$index, $state_name, $descr, '1', '1', null, null, '3', '3', $state); |
There was a problem hiding this comment.
You're missing the " around rcChasFanOperStatus and same with the below :)
its always the details. nice to have another pair of eyes. :-)
|
Auto-Deploy finished, Test PR at http://6693.ci.librenms.org or https://6693.ci.librenms.org |
|
The inspection completed: No new issues |
|
I hope I finally have this one right? laf thank you for your patience with my horrible code writing. :-) |
|
All good, thanks for contributing :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. |
Adding FAN and Power Supply support for Avaya VOSS(VSP operating systems platform)
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926