New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state support FAN, Power Supply Avaya VSP #6693

Merged
merged 4 commits into from May 23, 2017

Conversation

Projects
None yet
4 participants
@ospfbgp
Contributor

ospfbgp commented May 20, 2017

Adding FAN and Power Supply support for Avaya VOSS(VSP operating systems platform)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Add state support FAN, Power Supply Avaya VSP
Adding FAN and Power Supply support for Avaya VOSS(VSP operating systems platform)
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 20, 2017

Auto-Deploy finished, Test PR at http://6693.ci.librenms.org or https://6693.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 20, 2017

Auto-Deploy finished, Test PR at http://6693.ci.librenms.org or https://6693.ci.librenms.org

Show outdated Hide outdated includes/discovery/sensors/state/avaya-vsp.inc.php
}
}
discover_sensor($valid['sensor'], 'state', $device, $current_oid, $index, $state_name, $descr, '1', '1', null, null, '3', '3', $state);

This comment has been minimized.

@laf

laf May 20, 2017

Member

If $index is just single digits then it will conflict with the next state discovery.

Better to use "rcChasFanOperStatus.$index" in the discover_sensor() call. Same for below.

@laf

laf May 20, 2017

Member

If $index is just single digits then it will conflict with the next state discovery.

Better to use "rcChasFanOperStatus.$index" in the discover_sensor() call. Same for below.

Update avaya-vsp.inc.php
$index has been changed to rcChasFanOperStatus.$index and rcChasPowerSupplyOperStatus.$index in discover_sensor and create_sensor_to_state_index
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 21, 2017

Auto-Deploy finished, Test PR at http://6693.ci.librenms.org or https://6693.ci.librenms.org

Show outdated Hide outdated includes/discovery/sensors/state/avaya-vsp.inc.php
}
}
discover_sensor($valid['sensor'], 'state', $device, $current_oid, rcChasFanOperStatus.$index, $state_name, $descr, '1', '1', null, null, '3', '3', $state);

This comment has been minimized.

@laf

laf May 21, 2017

Member

You're missing the " around rcChasFanOperStatus and same with the below :)

@laf

laf May 21, 2017

Member

You're missing the " around rcChasFanOperStatus and same with the below :)

Update avaya-vsp.inc.php
its always the details.  nice to have another pair of eyes. :-)
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented May 22, 2017

Auto-Deploy finished, Test PR at http://6693.ci.librenms.org or https://6693.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier May 22, 2017

The inspection completed: No new issues

scrutinizer-notifier commented May 22, 2017

The inspection completed: No new issues

@ospfbgp

This comment has been minimized.

Show comment
Hide comment
@ospfbgp

ospfbgp May 22, 2017

Contributor

I hope I finally have this one right?

laf thank you for your patience with my horrible code writing. :-)

Contributor

ospfbgp commented May 22, 2017

I hope I finally have this one right?

laf thank you for your patience with my horrible code writing. :-)

@laf laf merged commit 407c0a4 into librenms:master May 23, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 23, 2017

Member

All good, thanks for contributing :)

Member

laf commented May 23, 2017

All good, thanks for contributing :)

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.