New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "system name" for the "Services list" #6873

Merged
merged 6 commits into from Jun 23, 2017

Conversation

Projects
None yet
5 participants
@algebur
Contributor

algebur commented Jun 21, 2017

service_01

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

algebur added some commits Jun 20, 2017

Add "system name" to "hostname"
It is easy to watch hosts using system names and IP addresses
Deleted -H for checking srevice
How wrote this code? 
I could not use additional plugins, because system adds "-H" when plugin runs. But some plugins don't use "-H"
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Jun 21, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Jun 21, 2017

CLA assistant check
All committers have signed the CLA.

Show outdated Hide outdated includes/services.inc.php

@laf laf added the Blocker 🚫 label Jun 21, 2017

algebur added some commits Jun 23, 2017

@algebur algebur changed the title from Added "system name" and changed $check_cmd for services to Added "system name" for the "Services list" Jun 23, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 23, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jun 23, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 23, 2017

Member

Please can you sign the CLA, we can't merge until this is done.

Member

laf commented Jun 23, 2017

Please can you sign the CLA, we can't merge until this is done.

@algebur

This comment has been minimized.

Show comment
Hide comment
@algebur

algebur Jun 23, 2017

Contributor

Ok. I did it

Contributor

algebur commented Jun 23, 2017

Ok. I did it

@laf laf merged commit 62cde81 into librenms:master Jun 23, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.