-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
newdevice: Add Calix AXOS/E5-16F Detection #6926
Conversation
Auto-Deploy finished, Test PR at http://6926.ci.librenms.org or https://6926.ci.librenms.org |
Does AXOS use the same mibs as E7? Also, this should probably be more generic like |
I'm trying to get the MIBs, but I believe they are different, as AXOS is the new software Calix is going to. 1.3.6.1.2.1.1.1.0|4|Calix, Inc E5-16F AXOS-R2.2.0 |
I mean we match by the start of the sysObectID string, so 1.3.6.1.4.1.6321.1.2.4. will likely match every AXOS device, not just E5-16F. (I had a typo in my message earlier) We probably need to start a new OS for AXOS if they have different MIBs. I suggest calix-axos The snmprec data is only used for testing to make sure we don't break os detection for devices. What you have there is correct. |
I just checked and it uses the same mibs as the e7. It actually uses less. |
Auto-Deploy finished, Test PR at http://6926.ci.librenms.org or https://6926.ci.librenms.org |
Auto-Deploy finished, Test PR at http://6926.ci.librenms.org or https://6926.ci.librenms.org |
So should we do this as a new OS axos.yaml if that's what this device runs? |
AXOS is basically the SDN (They like to call it SDA) platform for Calix. I don't think it is far off from their current E7 platform at the underpinnings. I just checked the MIBs. CALIX-PRODUCT-MIB and CALIX-SMI are the only custom MIBs they provide. They cover both product lines. I think it would make sense to have them separate, just in case. |
You confused me then as the email notification said no but this says yes :) @djamp42 if you can split this off into a new os called axos that would be ace, if you don't have time let us know and one of us will sort it out. |
@laf changed my mind and edited post. |
@laf I would rather you do it, just because I'm not a programmer by trade. If you need any other device info let me know. |
@djamp42 I've update this now, please test the update to make sure it does what you need. I've removed what appears to be non-relevant discovery for models in the calix range so this is limited. If you find it's missing something that was there when it was calix then let me know. |
Auto-Deploy finished, Test PR at http://6926.ci.librenms.org or https://6926.ci.librenms.org |
Thanks, Works fine, just added another E5 and was detected as Calix with this pull request. |
includes/polling/os/axos.inc.php
Outdated
|
||
|
||
// Device might not have a card 1 (or even card2 if it is an E7-20) | ||
$version = strtok(snmp_walk($device, "e7CardSoftwareVersion.1", "-OQv", "E7-Calix-MIB"), PHP_EOL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is relevant to the hardware.
@djamp42 can you snmpwalk these on your device and let us know if they are valid for the hardware?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E5-16F doesn't have slots, it's a single chassis of 16 gfast ports. My understanding is the E7 will support NG-PON2 and these new cards will run AXOS. They haven't been released yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djamp42 That seems to muddle things more... I'll do some research with my Calix contacts in a couple of days.
The inspection completed: No new issues |
Thanks for the pull request @djamp42 :) |
This thread has been automatically locked since there has not been any recent activity after it was closed. |
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926