feature: add timeout to AD auth, default is 5s #6967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Naughty powerwalker @murrant :) |
|
Auto-Deploy finished, Test PR at http://6967.ci.librenms.org or https://6967.ci.librenms.org |
Can be configured by $config['auth_ad_timeout']
|
Auto-Deploy finished, Test PR at http://6967.ci.librenms.org or https://6967.ci.librenms.org |
|
Is it easy enough to add a reconnect in so if the connection has timed out it will just auto connect rather than kick the user our (just spit balling) |
laf
approved these changes
Jul 5, 2017
|
Auto-Deploy finished, Test PR at http://6967.ci.librenms.org or https://6967.ci.librenms.org |
|
The inspection completed: No new issues |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be configured by $config['auth_ad_timeout']
One of my ad servers stop responding to ldap requests and LibreNMS never tried to use the second ad server, just gave a http timeout error.
Adding a timeout allows ldap to give up and try additional servers, or at least actually return some html (which will print an connection failed error).
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926