New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add timeout to AD auth, default is 5s #6967

Merged
merged 2 commits into from Jul 8, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Jul 5, 2017

Can be configured by $config['auth_ad_timeout']

One of my ad servers stop responding to ldap requests and LibreNMS never tried to use the second ad server, just gave a http timeout error.

Adding a timeout allows ldap to give up and try additional servers, or at least actually return some html (which will print an connection failed error).

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 5, 2017

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

mention-bot commented Jul 5, 2017

Thank you for submitting a PR @murrant! We have found the following @laf based on the history of these files to review this PR.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 5, 2017

Member

Naughty powerwalker @murrant :)

Member

laf commented Jul 5, 2017

Naughty powerwalker @murrant :)

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 5, 2017

Auto-Deploy finished, Test PR at http://6967.ci.librenms.org or https://6967.ci.librenms.org

feature: add timeout to AD auth, default is 5s
Can be configured by $config['auth_ad_timeout']
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 5, 2017

Auto-Deploy finished, Test PR at http://6967.ci.librenms.org or https://6967.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 5, 2017

Member

Is it easy enough to add a reconnect in so if the connection has timed out it will just auto connect rather than kick the user our (just spit balling)

Member

laf commented Jul 5, 2017

Is it easy enough to add a reconnect in so if the connection has timed out it will just auto connect rather than kick the user our (just spit balling)

@laf

laf approved these changes Jul 5, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 7, 2017

Auto-Deploy finished, Test PR at http://6967.ci.librenms.org or https://6967.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 7, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 7, 2017

The inspection completed: No new issues

@murrant murrant merged commit 50b3ffb into librenms:master Jul 8, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:ad-timeout branch Jul 8, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.