Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Alert-Groups (Backend) #712

Closed
wants to merge 1 commit into from
Closed

Added Alert-Groups (Backend) #712

wants to merge 1 commit into from

Conversation

f0o
Copy link
Member

@f0o f0o commented Apr 2, 2015

This PR adds Alert-Groups.

Alert-Groups are created in the table alert_groups. It expects a name and a desc. Both can be any kind of text.

A device is added to the group by adding an entry into the device_attribs table using alert_group for attrib_type and the group's alert_groups.id for attrib_value.

To maintain overview, the column alert_rules.device_id has been renamed to alert_rules.target.

To apply a rule to an alert-group, set alert_rules.target to alert_groups.id prefixed with a g.
Example: g1 for Group with alert_groups.id of 1.

This PR does not include any form of Frontend to populate the tables. This will be done separately.

Note: Because this PR renames a widely used column it requires indepth testing and revision!
Please drop me some comments in case I missed some files that still depend on alert_rules.device_id !

(Related: #616)

Renamed `alert_rules.device_id` to `alert_rules.target`
@laf
Copy link
Member

laf commented Apr 2, 2015

Running on my test install now.

@f0o
Copy link
Member Author

f0o commented Apr 2, 2015

GUI draft: master...f0o:issue-616-frontend

@f0o
Copy link
Member Author

f0o commented Apr 2, 2015

Reworking like discussed on IRC.

@f0o f0o closed this Apr 2, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants