-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New os Alcoma #7476
New os Alcoma #7476
Conversation
Thanks @erotel. All looks good, just a question on the os name. It's usually not a good idea to base it on the vendor name. Looking at the firmware for this device it doesn't appear to be called anything but to safeguard the vendor building a new product line should we use |
this device does not support ssh or telnet, so I do not know the system name. |
@erotel seems fine with me, |
LibreNMS/OS/AlcomaAlmp.php
Outdated
@@ -0,0 +1,97 @@ | |||
<?php | |||
/** | |||
* Alcoma.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For completeness may as well change this
The inspection completed: 2 new issues, 5 updated code elements |
This thread has been automatically locked since there has not been any recent activity after it was closed. |
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926