fix: improve poller validation #7586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove failures when there are duplicate poller entries add warning that there are duplicate poller entries link to the poller log in the webui small fix to getBaseURL() to avoid exception when run from cli.
|
Worth applying 212.sql again as another schema update? |
|
@laf I dunno maybe, I think it was a timing issue. This at least reports the correct issues even if there are duplicates. |
|
I think we should, no harm in doing so and it will save the expected questions we will get asked or at least stop users having to manually fix. |
|
Want it in this PR or a separate one? |
|
This one makes the most sense. Happy to merge straight after that. |
|
The inspection completed: 20 new issues, 3 updated code elements |
murrant
added a commit
that referenced
this pull request
Nov 1, 2017
* fix: improve poller validation remove failures when there are duplicate poller entries add warning that there are duplicate poller entries link to the poller log in the webui small fix to getBaseURL() to avoid exception when run from cli. * Re-run poller cleanup to try to reduce the users with duplicates.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove failures when there are duplicate poller entries
add warning that there are duplicate poller entries
link to the poller log in the webui
small fix to getBaseURL() to avoid exception when run from cli.
extract poller validations to private methods for better readability
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926