New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve poller validation #7586

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Oct 30, 2017

remove failures when there are duplicate poller entries
add warning that there are duplicate poller entries
link to the poller log in the webui
small fix to getBaseURL() to avoid exception when run from cli.
extract poller validations to private methods for better readability

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: improve poller validation
remove failures when there are duplicate poller entries
add warning that there are duplicate poller entries
link to the poller log in the webui
small fix to getBaseURL() to avoid exception when run from cli.
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 30, 2017

Member

Worth applying 212.sql again as another schema update?

Member

laf commented Oct 30, 2017

Worth applying 212.sql again as another schema update?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 30, 2017

Member

@laf I dunno maybe, I think it was a timing issue. This at least reports the correct issues even if there are duplicates.

Member

murrant commented Oct 30, 2017

@laf I dunno maybe, I think it was a timing issue. This at least reports the correct issues even if there are duplicates.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 30, 2017

Member

I think we should, no harm in doing so and it will save the expected questions we will get asked or at least stop users having to manually fix.

Member

laf commented Oct 30, 2017

I think we should, no harm in doing so and it will save the expected questions we will get asked or at least stop users having to manually fix.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 30, 2017

Member

Want it in this PR or a separate one?

Member

murrant commented Oct 30, 2017

Want it in this PR or a separate one?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 30, 2017

Member

This one makes the most sense. Happy to merge straight after that.

Member

laf commented Oct 30, 2017

This one makes the most sense. Happy to merge straight after that.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 30, 2017

The inspection completed: 20 new issues, 3 updated code elements

scrutinizer-notifier commented Oct 30, 2017

The inspection completed: 20 new issues, 3 updated code elements

@laf laf merged commit d809bdd into librenms:master Oct 31, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request Nov 1, 2017

fix: Improve poller validation (librenms#7586)
* fix: improve poller validation
remove failures when there are duplicate poller entries
add warning that there are duplicate poller entries
link to the poller log in the webui
small fix to getBaseURL() to avoid exception when run from cli.

* Re-run poller cleanup to try to reduce the users with duplicates.

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request Nov 1, 2017

fix: Improve poller validation (librenms#7586)
* fix: improve poller validation
remove failures when there are duplicate poller entries
add warning that there are duplicate poller entries
link to the poller log in the webui
small fix to getBaseURL() to avoid exception when run from cli.

* Re-run poller cleanup to try to reduce the users with duplicates.

murrant added a commit that referenced this pull request Nov 1, 2017

fix: Improve poller validation (#7586)
* fix: improve poller validation
remove failures when there are duplicate poller entries
add warning that there are duplicate poller entries
link to the poller log in the webui
small fix to getBaseURL() to avoid exception when run from cli.

* Re-run poller cleanup to try to reduce the users with duplicates.
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.