New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick script to rename mibs to their proper names #8068

Merged
merged 1 commit into from Jan 11, 2018

Conversation

Projects
None yet
3 participants
@murrant
Copy link
Member

murrant commented Jan 11, 2018

So I can stop re-writing it ;)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Quick script to rename mibs to their proper names
So I can stop re-writing it ;)
@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Jan 11, 2018

The inspection completed: 2 new issues, 2 updated code elements

@laf

This comment has been minimized.

Copy link
Member

laf commented Jan 11, 2018

Is this not just a little easier to exec grep 'DEFINITIONS ::= BEGIN' ./mibs/IF-MIB|cut -d ' ' -f1?

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Jan 11, 2018

@laf the problem is some mib files have the definitions spread out over multiple lines and even comments in the middle...

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Jan 11, 2018

I've coded this tool about 3 times, so I figured I might as well save it so I don't keep writing it.

@laf laf added the Feature label Jan 11, 2018

@laf laf merged commit cabc0eb into librenms:master Jan 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:mib-renamer branch Jan 12, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.