New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config loading into the Config class. #8100

Merged
merged 1 commit into from Feb 10, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Jan 17, 2018

Self contain dbFacile too.
Update rrdtool default setting to be similar to others.
Move silly cisco-entities.php into entity-physical.inc.php

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf laf added the Refactor label Jan 17, 2018

@laf

This comment has been minimized.

Member

laf commented Jan 25, 2018

Testing on my dev install, will merge tomorrow if it works ok.

Move config loading into the Config class.
Self contain dbFacile too.
Update rrdtool default setting to be similar to others.
Move silly cisco-entities.php into entity-physical.inc.php
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 9, 2018

The inspection completed: 2 new issues, 9 updated code elements

@laf

This comment has been minimized.

Member

laf commented Feb 10, 2018

Tested full discovery, had polling running for > 6 hours. Web interface seems to work as expected so I'm happy with this.

@laf laf merged commit de56dcc into librenms:master Feb 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:config-centralize branch Feb 11, 2018

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

refactor: Move config loading into the Config class. (librenms#8100)
Self contain dbFacile too.
Update rrdtool default setting to be similar to others.
Move silly cisco-entities.php into entity-physical.inc.php
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.