New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct unix socket handling to match poller-wrapper #8214

merged 1 commit into from Feb 9, 2018


None yet
5 participants

tduehr commented Feb 6, 2018


Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.


If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This comment has been minimized.

CLAassistant commented Feb 6, 2018

CLA assistant check
All committers have signed the CLA.


Thanks, must have gotten missed.

Can you make it match the code in poller-wrapper?

@@ -93,7 +93,8 @@ def get_config_data():
db_server = config['db_host']
db_port = 0
elif config['db_socket']:
db_server = config['db_socket']
db_server = config['db_host']
db_socket = config['db_socket']
db_port = 0

This comment has been minimized.


murrant Feb 7, 2018


Remove db_port = 0

@@ -104,7 +105,7 @@ def get_config_data():
def db_open():
if db_port == 0:

This comment has been minimized.


murrant Feb 7, 2018


change this to if db_socket:


This comment has been minimized.

scrutinizer-notifier commented Feb 9, 2018

The inspection completed: No new issues

@laf laf merged commit 2793958 into librenms:master Feb 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
license/cla Contributor License Agreement is signed.

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018


This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.