-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct unix socket handling to match poller-wrapper #8214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, must have gotten missed.
Can you make it match the code in poller-wrapper?
discovery-wrapper.py
Outdated
@@ -93,7 +93,8 @@ def get_config_data(): | |||
db_server = config['db_host'] | |||
db_port = 0 | |||
elif config['db_socket']: | |||
db_server = config['db_socket'] | |||
db_server = config['db_host'] | |||
db_socket = config['db_socket'] | |||
db_port = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove db_port = 0
discovery-wrapper.py
Outdated
@@ -104,7 +105,7 @@ def get_config_data(): | |||
def db_open(): | |||
try: | |||
if db_port == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this to if db_socket:
cf2a616
to
b2daba2
Compare
The inspection completed: No new issues |
This thread has been automatically locked since there has not been any recent activity after it was closed. |
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926