New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Prometheus PushGateway support #8437

Merged
merged 6 commits into from Apr 13, 2018

Conversation

Projects
None yet
5 participants
@cchance27
Contributor

cchance27 commented Mar 21, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

CLAassistant commented Mar 21, 2018

CLA assistant check
All committers have signed the CLA.

cchance27 added some commits Mar 21, 2018

@laf

This comment has been minimized.

Member

laf commented Apr 2, 2018

@cchance27 Thanks for this and sorry for the delay in responding.

looks like the Prometheus.md file is missing. If you can add that, we'll ask for people to test this.

@cchance27

This comment has been minimized.

Contributor

cchance27 commented Apr 4, 2018

hey @laf had done it already but forgot to add it to the commit, just added it

@laf laf added the Needs Testing label Apr 4, 2018

@laf

Code LGTM. Can't test and calls for others to test have failed so we should just merge as is.

@librenms/reviewers

@murrant

LGTM, Maybe we should have a switch to disable all?

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 13, 2018

The inspection completed: 1 updated code elements

@laf

laf approved these changes Apr 13, 2018

LGTM

@laf laf merged commit 09d6b2f into librenms:master Apr 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@cchance27 cchance27 deleted the cchance27:prometheus-push branch Apr 13, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

feature: Added Prometheus PushGateway metric support (librenms#8437)
* Added Prometheus PushGateway support

* fixed formatting

* fix set_curl_proxy to correct variable

* add documentation

* Update Metric-Storage.md

* Update mkdocs.yml

@lock lock bot locked as resolved and limited conversation to collaborators Jun 12, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.