Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Prometheus PushGateway support #8437

Merged
merged 6 commits into from
Apr 13, 2018
Merged

Added Prometheus PushGateway support #8437

merged 6 commits into from
Apr 13, 2018

Conversation

cchance27
Copy link
Contributor

@cchance27 cchance27 commented Mar 21, 2018 •
edited
Loading

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@laf
Copy link
Member

laf commented Apr 2, 2018

@cchance27 Thanks for this and sorry for the delay in responding.

looks like the Prometheus.md file is missing. If you can add that, we'll ask for people to test this.

@cchance27
Copy link
Contributor Author

hey @laf had done it already but forgot to add it to the commit, just added it

@laf laf added the Needs Testing Waiting for others to verify that the code functions properly. label Apr 4, 2018
laf
laf reviewed Apr 12, 2018
View reviewed changes
Copy link
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Can't test and calls for others to test have failed so we should just merge as is.

@librenms/reviewers

murrant
murrant previously approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Maybe we should have a switch to disable all?

@scrutinizer-notifier
Copy link

The inspection completed: 1 updated code elements

laf
laf approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laf laf merged commit 09d6b2f into librenms:master Apr 13, 2018
@cchance27 cchance27 deleted the prometheus-push branch April 13, 2018 18:36
TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018
@cchance27 @TheMysteriousX
feature: Added Prometheus PushGateway metric support (librenms#8437)
9fbd3ba 
* Added Prometheus PushGateway support

* fixed formatting

* fix set_curl_proxy to correct variable

* add documentation

* Update Metric-Storage.md

* Update mkdocs.yml
@lock lock bot locked as resolved and limited conversation to collaborators Jun 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laf laf laf approved these changes

@murrant murrant murrant left review comments

Assignees
No one assigned
Labels
Needs Testing Waiting for others to verify that the code functions properly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cchance27 @CLAassistant @laf @scrutinizer-notifier @murrant