New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the description of Application support #8619
Conversation
I was not aware that the applications can also be auto-discovered. I discovered it by chance, and when I mentioned it in discord channel, it seemed blatantly obvious to everyone else. Thought editing the docs might help future users.
doc/Extensions/Applications.md
Outdated
@@ -3,6 +3,8 @@ source: Extensions/Applications.md | |||
|
|||
You can use Application support to graph performance statistics from many applications. | |||
|
|||
Note that the monitoring of applications could be added before or after the hosts have been added to LibreNMS. If your device is already in LibreNMS, you will need to go and edit the pertaining device, and enable the application(s) you want to monitor. If the device is not in LibreNMS yet, don't sweat, because adding the agent or snmp extend scripts before adding the device will make the application auto-discoverable by LibreNMS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should also be auto discovered even if setting up an app after the device is added in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean without manually enabling it per device, if the device is already in LNMS? Then maybe I should look at the page as a whole? Rethink the way all of it fits together? Some apps contain the part about "remember to edit your device in LNMS after configuring XYZ" and some apps don't. So maybe I should spend time over the weekend on this, if you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
If using an snmp extend then the application discovery module will pick it up. The application discovery module is enabled by default for most *nix operating systems. (otherwise you will have to manually enable that discovery module)
The unix-agent does not have a discovery module, only a poller module. That poller module is always disabled by default. It needs to be manually enabled if using the agent. Some applications will be automatically enabled by the unix-agent poller module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add this overview to the page. I am not aware that it is written up somewhere else? I am willing to rewrite a lot of the stuff on the page, but don't want to create a lot of unnecessary work for the reviewers/mergers. If you want me to go ahead, I will do so over the weekend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do go ahead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have changed a lot in the file. Did not want to split it up into multiple PR's, as a lot of it was just copy and paste.
Changed a lot of instructions to make it more structured.
Images can be added in |
Addedimages to help with application extensions how-to.
Added the file locations into master file.
The inspection completed: No new issues |
The inspection completed: No new issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kkrumm1 did you read through this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Over to @kkrumm1
Looks good to me. @hanserasmus Good work brotha! :) |
* Revert "device: Add NTP support for Allied Telesis AWPlus products (#8580)" This reverts commit e898075. * Revert " Restore OpenBSD version/features/hardware (#8673)" This reverts commit b94ad92. * Revert "Expand the description of Application support (#8619)" This reverts commit 8ce423d. * Revert "Documentation updates for DMI support and making two links in the FAQ work (#8440)" This reverts commit a7437c1. * Revert "webui: Make two-factor auth logo use response (#8652)" This reverts commit 3e0c26f. * Revert "fix: Updated Discovery on Ceragon to re-add wireless (#8647)" This reverts commit ce2b9f9. * Revert "feature: Add check_http service custom command (#8675)" This reverts commit a1f92a9.
* Expand the description of Application support I was not aware that the applications can also be auto-discovered. I discovered it by chance, and when I mentioned it in discord channel, it seemed blatantly obvious to everyone else. Thought editing the docs might help future users. * Update Applications.md Changed a lot of instructions to make it more structured. * Add files via upload Addedimages to help with application extensions how-to. * Update Applications.md Added the file locations into master file.
* Revert "device: Add NTP support for Allied Telesis AWPlus products (librenms#8580)" This reverts commit e898075. * Revert " Restore OpenBSD version/features/hardware (librenms#8673)" This reverts commit b94ad92. * Revert "Expand the description of Application support (librenms#8619)" This reverts commit 8ce423d. * Revert "Documentation updates for DMI support and making two links in the FAQ work (librenms#8440)" This reverts commit a7437c1. * Revert "webui: Make two-factor auth logo use response (librenms#8652)" This reverts commit 3e0c26f. * Revert "fix: Updated Discovery on Ceragon to re-add wireless (librenms#8647)" This reverts commit ce2b9f9. * Revert "feature: Add check_http service custom command (librenms#8675)" This reverts commit a1f92a9.
I was not aware that the applications can also be auto-discovered. I discovered it by chance, and when I mentioned it in discord channel, it seemed blatantly obvious to everyone else. Thought editing the docs might help future users.
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926